Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable async API client by default when using example app #4505

Merged

Conversation

mats-stripe
Copy link
Collaborator

Summary

Turns on the async API client by default when using the FC Example app. API client used in production is still the "legacy" Futures / Promise based client. This change will have no effect outside of example app usage

Motivation

This for us to dogfood this client to gain confidence in it

Testing

N/a

Changelog

N/a

@mats-stripe mats-stripe requested review from a team as code owners January 24, 2025 20:56
Copy link

⚠️ Public API changes detected:

StripePaymentSheet

- case integrationError(nonPIIDebugDescription: Swift.String)

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@mats-stripe mats-stripe force-pushed the mats/enabled_async_api_client_by_default_when_debugging branch from 2d2a138 to 8e5de07 Compare January 26, 2025 16:26
@mats-stripe mats-stripe merged commit a8baad4 into master Jan 27, 2025
6 checks passed
@mats-stripe mats-stripe deleted the mats/enabled_async_api_client_by_default_when_debugging branch January 27, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants