Add attestation event logging to FC API clients #4481
Merged
+314
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mats-stripe
force-pushed
the
mats/attestion_event_logging
branch
from
d8d06bc to
2193645
Compare
mats-stripe
commented
Jan 20, 2025
...ons/StripeFinancialConnections/Source/API Bindings/FinancialConnectionsAPIClientLogger.swift
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| var parameters: [String: Any] { |
There was a problem hiding this comment.
@carlosmuvi-stripe let me know which other parameters we should include for each event
There was a problem hiding this comment.
I think we should be good with these + the default parameters sent on all requests
mats-stripe
force-pushed
the
mats/fc_mobile_lookup_endpoint
branch
from
ac88f3b to
dba58e6
Compare
mats-stripe
force-pushed
the
mats/attestion_event_logging
branch
from
2193645 to
187a2b2
Compare
mats-stripe
commented
Jan 20, 2025
| @@ -174,6 +174,7 @@ extension FinancialConnectionsAnalyticsClient { | |||
| additionalParameters["single_account"] = manifest.singleAccount | |||
| additionalParameters["allow_manual_entry"] = manifest.allowManualEntry | |||
| additionalParameters["account_holder_id"] = manifest.accountholderToken | |||
| additionalParameters["app_verification_enabled"] = manifest.appVerificationEnabled | |||
There was a problem hiding this comment.
Includes manifest.appVerificationEnabled as a common field, passed along to most logs we emit.
mats-stripe
force-pushed
the
mats/fc_mobile_lookup_endpoint
branch
from
45040b1 to
89bc90c
Compare
mats-stripe
force-pushed
the
mats/attestion_event_logging
branch
from
6a46135 to
27b77d0
Compare
mats-stripe
force-pushed
the
mats/attestion_event_logging
branch
from
27b77d0 to
4801101
Compare
mats-stripe
force-pushed
the
mats/attestion_event_logging
branch
from
4801101 to
5f5d685
Compare
carlosmuvi-stripe
approved these changes
Jan 23, 2025
tillh-stripe
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds logging for various attestation-related events in our Financial Connections API clients (both legacy and async clients). Most of the event logging logic has been consolidated in
FinancialConnectionsAPIClientLogger. As part of this, I also had to make a few secondary changes to the API clients;/synchronizecall.paneandapithrough the consumer session lookup and sign up APIs for logging purposes.Motivation
https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?tab=t.0#bookmark=kix.oi6g969wwrz0
Testing
N/a
Changelog
N/a