Add express login link to furever #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgea-stripe
requested changes
Jan 23, 2025
app/(dashboard)/settings/layout.tsx
Outdated
|
|
||
| const expressDashboardLoginLink = useMemo(async () => { | ||
| if (hasExpressDashboardAccess) { | ||
| const res = await fetch('/api/login_link'); |
There was a problem hiding this comment.
Can we abstract this into a hook, like https://github.com/stripe/stripe-connect-furever-demo/blob/master/app/hooks/useFinancialAccount.ts?
There was a problem hiding this comment.
I am a bit disappointed we don't use react-query 🤦
jorgea-stripe
approved these changes
Jan 23, 2025
jorgea-stripe
approved these changes
Jan 23, 2025
|
|
||
| useEffect(() => { | ||
| const fetchLink = async () => { | ||
| const res = await fetch('/api/login_link'); |
There was a problem hiding this comment.
@dhiggins-stripe this is going to fail for anyone that is not express. Can we add an if here to only make this request if it is an express account?
There was a problem hiding this comment.
I see you have the check above, but it is best to not make the API request at all in that case!
Jacksonearl2468
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merchant has express dashboard access, display link to open express dashboard
Screen.Recording.2025-01-23.at.2.33.27.PM.mov