Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmbeddedFormHelperFactory #9990

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

tjclawson-stripe
Copy link
Collaborator

Summary

Create EmbeddedFormHelperFactory

Motivation

Re-use logic for EmbeddedContentHelper and FormActivityViewModel

Testing

  • Added tests
  • Modified tests
  • Manually verified

@tjclawson-stripe tjclawson-stripe force-pushed the tyler/form-helper-factory branch from 0aed18e to d0ccd7b Compare January 27, 2025 15:25
@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review January 27, 2025 15:25
@tjclawson-stripe tjclawson-stripe requested review from a team as code owners January 27, 2025 15:25
coroutineScope: CoroutineScope,
paymentMethodMetadata: PaymentMethodMetadata,
linkConfigurationCoordinator: LinkConfigurationCoordinator,
currentSelection: PaymentSelection?,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be easier to make this class injectable, and replace this with EmbeddedSelectionHolder instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

@tjclawson-stripe tjclawson-stripe marked this pull request as draft January 27, 2025 15:28
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ +8 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +8 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19975 │ 19975 │ 0 (+0 -0) 
   types │  6193 │  6193 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17538 │ 17538 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 28.5 KiB │ +8 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    270 B │ -2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
 25.4 KiB │ +1 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 55.3 KiB │ +8 B │ 127.4 KiB │  0 B │ (total)

@tjclawson-stripe tjclawson-stripe marked this pull request as ready for review January 27, 2025 15:57
samer-stripe
samer-stripe previously approved these changes Jan 27, 2025
@tjclawson-stripe tjclawson-stripe enabled auto-merge (squash) January 27, 2025 16:28
@tjclawson-stripe tjclawson-stripe merged commit f1673e9 into master Jan 27, 2025
13 checks passed
@tjclawson-stripe tjclawson-stripe deleted the tyler/form-helper-factory branch January 27, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants