-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elements/session
analytics for CustomerSession
on CustomerSheet
#9395
Add elements/session
analytics for CustomerSession
on CustomerSheet
#9395
Conversation
@@ -288,6 +324,7 @@ class DefaultCustomerSessionElementsSessionManagerTest { | |||
) | |||
|
|||
assertThat(errorReporter.getLoggedErrors()).containsExactly( | |||
ErrorReporter.SuccessEvent.CUSTOMER_SHEET_CUSTOMER_SESSION_ELEMENTS_SESSION_LOAD_SUCCESS.eventName, | |||
ErrorReporter | |||
.UnexpectedErrorEvent | |||
.CUSTOMER_SESSION_ON_CUSTOMER_SHEET_ELEMENTS_SESSION_NO_CUSTOMER_FIELD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We expect that both of these are fired. We should indicate if elements/session
was loaded successfully from the endpoint but the unexpected error indicates to us that the response is malformed.
The malformed response should never happen. We have client-side validation to ensure merchants aren't sending old ephemeral keys to elements/session
and server-side validation should take care of the rest. If the customer
field is not available. Something erroneous has occurred on the elements/session
side.
Diffuse output:
APK
DEX
|
8f0f43d
to
cce31f9
Compare
Summary
Add
elements/session
analytics forCustomerSession
onCustomerSheet
Motivation
Track success & failed loads for
elements/session
onCustomerSheet
withCustomerSession
.Testing