Add CustomerSessionClientSecret validation & remodel ElementsSessionManager response.
#9373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
force-pushed
the
samer/elements-session-manager-validation-remodel
branch
from
40f506d to
49f3cc2
Compare
3 tasks
…onManager` response.
samer-stripe
force-pushed
the
samer/elements-session-manager-validation-remodel
branch
from
49f3cc2 to
2cc22be
Compare
amk-stripe
reviewed
Oct 1, 2024
| }.getOrThrow() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun validateCustomerSessionClientSecret(customerSessionClientSecret: String) { |
There was a problem hiding this comment.
is there a way we can share this code with payment sheet rather than re-implementing it?
There was a problem hiding this comment.
Added a CustomerSessionClientSecretProvider that does the actual validation. Error messages are still different between both implementations given the context in how the errors are produced is different between both PaymentSheet and CustomerSheet.
samer-stripe
commented
Oct 1, 2024
| private val timeProvider: () -> Long, | ||
| @IOContext private val workContext: CoroutineContext, | ||
| ) : CustomerSessionElementsSessionManager { | ||
| @Volatile | ||
| private var cachedCustomerEphemeralKey: CachedCustomerEphemeralKey = CachedCustomerEphemeralKey.None | ||
| private var cachedCustomerEphemeralKey: CachedCustomerEphemeralKey? = null |
There was a problem hiding this comment.
Decided to convert this back to a nullable type with no sealed interface since None serves no value after changes made here.
|
Diffuse output: APKDEX |
samer-stripe
force-pushed
the
samer/elements-session-manager-validation-remodel
branch
from
e197a9c to
525111a
Compare
amk-stripe
approved these changes
Oct 1, 2024
|
|
||
| suspend fun fetchElementsSession(): Result<ElementsSession> | ||
| suspend fun fetchElementsSession(): Result<CustomerSessionElementsSession> |
There was a problem hiding this comment.
fwiw I think that CustomerSessionElementsSession could also be a completely internal type, and the return type of this function could be unchanged. I don't think there are any consumers of this function yet though, so it's unclear to me which will be more ergonomic!
There was a problem hiding this comment.
Actually CustomerSessionPaymentMethodDataSource consumes the result of this function! The type helps ensure ElementsSession.Customer is not null unlike the ElementsSession type which can have it null. This way, CustomerSessionElementsSessionManager is responsible for ensuring that the customer field is available and not the individual data sources.
There was a problem hiding this comment.
oh gotcha. Nice! That's great
| }.getOrThrow() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun validateCustomerSessionClientSecret(customerSessionClientSecret: String) { |
samer-stripe
deleted the
samer/elements-session-manager-validation-remodel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
CustomerSessionClientSecretvalidation & remodelElementsSessionManagerresponse.Motivation
We validate on the client-side if the provided key is a valid customer session key for
PaymentSheetand should do the same forCustomerSheet. With this validation, we can now expectelements/sessionto return acustomerfield soElementsSessionManagernow provides a response withElementsSessionand a non-null customer.Testing