-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose 1.6 round two #9345
Compose 1.6 round two #9345
Conversation
Diffuse output:
APK
DEX
ARSC
|
f4213cc
to
36dcbc2
Compare
5e73c10
to
81ac999
Compare
d8b4f2d
to
04d7454
Compare
04d7454
to
33cc5cf
Compare
...common.ui_PrimaryButtonScreenshotTest_testDisabled[DarkTheme,CustomAppearance,LargeFont].png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link, paymentsheet, and paymentsheet-example lgtm!
...bacs_BacsMandateButtonScreenshotTest_testSecondary[DarkTheme,CustomAppearance,LargeFont].png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on FC! Thanks for doing this 👏
6cb1c9d
33cc5cf
to
6cb1c9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cardscan changes are fine by me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Summary
Upgrade to Compose 1.6.
The change is split into 3 parts.
ruby scripts/dependencies/update_transitive_dependencies.rb
)../gradlew recordPaparazziDebug
).Dependency update policy proposal here: https://docs.google.com/document/d/1qxLy7LwOI7cKzRS7RoolMAvtu9tti2dmo_CajmUrgdk/edit#heading=h.1an7utgp6hx