Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error code to payment failure analytic event #9135

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

amk-stripe
Copy link
Collaborator

Summary

Add error code to payment failure analytic event

Motivation

Parity with iOS. Adding as part of ensuring vertical mode analytics are complete.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@amk-stripe amk-stripe marked this pull request as ready for review August 27, 2024 22:02
@amk-stripe amk-stripe requested review from a team as code owners August 27, 2024 22:02
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├─────────────┬─────────────┬──────┼─────────────┬─────────────┬──────
 APK      │ old         │ new         │ diff │ old         │ new         │ diff 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
      dex │       2 MiB │       2 MiB │  0 B │     4.2 MiB │     4.2 MiB │  0 B 
     arsc │ 1,023.9 KiB │ 1,023.9 KiB │  0 B │ 1,023.8 KiB │ 1,023.8 KiB │  0 B 
 manifest │     2.3 KiB │     2.3 KiB │  0 B │       8 KiB │       8 KiB │  0 B 
      res │   301.5 KiB │   301.5 KiB │  0 B │     455 KiB │     455 KiB │  0 B 
   native │     6.2 MiB │     6.2 MiB │  0 B │    15.8 MiB │    15.8 MiB │  0 B 
    asset │     6.7 KiB │     6.7 KiB │  0 B │     6.4 KiB │     6.4 KiB │  0 B 
    other │    85.5 KiB │    85.5 KiB │ -5 B │   158.7 KiB │   158.7 KiB │  0 B 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
    total │     9.6 MiB │     9.6 MiB │ -5 B │    21.6 MiB │    21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21310 │ 21310 │ 0 (+0 -0) 
   types │  6771 │  6771 │ 0 (+0 -0) 
 classes │  5560 │  5560 │ 0 (+0 -0) 
 methods │ 31123 │ 31123 │ 0 (+0 -0) 
  fields │ 18155 │ 18155 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3392 │ 3392 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 28.3 KiB │ -9 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.1 KiB │ +3 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼───────────┼──────┼────────────────────────
 54.6 KiB │ -5 B │ 126.3 KiB │  0 B │ (total)

@amk-stripe amk-stripe enabled auto-merge (squash) August 27, 2024 22:10
@amk-stripe amk-stripe merged commit 2f07d89 into master Aug 27, 2024
13 checks passed
@amk-stripe amk-stripe deleted the add-error-code-to-payment-failure-event branch August 27, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants