LinkAuth abstraction for lookup and signup #10019

toluo-stripe · 2025-01-28T22:49:27Z

Summary

LinkAuth will be used as an abstraction to call lookup and signup. It will use attestation endpoints when the attestation flag is enabled. It will use the old endpoints otherwise. LinkAuth will replace LinkAccountManager in

SignUpVieModel (for look up and signup)
LinkActivityViewModel (for look up)

LinkAuth uses LinkAccountManager and IntegrityRequestManager underneath.

Motivation

JIRA

Testing

Added tests
Modified tests
Manually verified

github-actions · 2025-01-28T22:55:30Z

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.4 KiB │  90.4 KiB │ +8 B │ 170.7 KiB │ 170.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +8 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19975 │ 19975 │ 0 (+0 -0) 
   types │  6193 │  6193 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17538 │ 17538 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0

APK

   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 28.5 KiB │ +4 B │  63.1 KiB │  0 B │ ∆ META-INF/CERT.SF                        
 25.4 KiB │ +4 B │    63 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │ +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 55.3 KiB │ +8 B │ 127.4 KiB │  0 B │ (total)

toluo-stripe · 2025-01-28T22:56:09Z

paymentsheet/src/main/java/com/stripe/android/link/account/DefaultLinkAuth.kt

+    private val Throwable.isAttestationError: Boolean
+        get() = when (this) {
+            // Stripe backend could not verify the intregrity of the request
+            is APIException -> stripeError?.code == "link_failed_to_attest_request"
+            // Interaction with Integrity API to generate tokens resulted in a failure
+            is AttestationError -> true
+            else -> false
+        }


This logic was obtained from FC

instead of copying this fn could we move it into a location where both FC + PaymentSheet can use it? e.g. I think payments-core may be used by both

amk-stripe · 2025-01-29T17:44:15Z

paymentsheet/src/test/java/com/stripe/android/link/account/DefaultLinkAuthTest.kt

+    }
+
+    @Test
+    fun `sign in attempt with token fetch failure returns AttestationFailed`() = runTest {


how is this different from the test case above?

amk-stripe · 2025-01-29T17:59:38Z

paymentsheet/src/main/java/com/stripe/android/link/account/DefaultLinkAuth.kt

+    private val Throwable.isAttestationError: Boolean
+        get() = when (this) {
+            // Stripe backend could not verify the intregrity of the request
+            is APIException -> stripeError?.code == "link_failed_to_attest_request"
+            // Interaction with Integrity API to generate tokens resulted in a failure
+            is AttestationError -> true
+            else -> false
+        }


instead of copying this fn could we move it into a location where both FC + PaymentSheet can use it? e.g. I think payments-core may be used by both

amk-stripe · 2025-01-29T18:07:07Z

paymentsheet/src/main/java/com/stripe/android/link/account/DefaultLinkAuth.kt

There are several places in this file where getOrThrow is being used on a result -- can you update to instead take advantage of the result type (ie use something like .onSuccess and .onFailure?

amk-stripe · 2025-01-29T18:08:16Z

paymentsheet/src/main/java/com/stripe/android/link/account/DefaultLinkAuth.kt

+        return signupResult.toLinkAuthResult()
+    }
+
+    override suspend fun lookUp(


Should this function be named lookUpConsumer for consistency with LinkAccountManager?

ok to do in a follow up

amk-stripe

Ok to address PR comments later

toluo-stripe commented Jan 28, 2025

View reviewed changes

toluo-stripe marked this pull request as ready for review January 28, 2025 22:58

toluo-stripe requested review from a team as code owners January 28, 2025 22:58

toluo-stripe requested review from jaynewstrom-stripe, amk-stripe and carlosmuvi-stripe January 28, 2025 22:58

amk-stripe reviewed Jan 29, 2025

View reviewed changes

amk-stripe previously approved these changes Jan 29, 2025

View reviewed changes

toluo-stripe force-pushed the tolu/link/link_auth_interface branch from ad0f050 to 7b949db Compare January 29, 2025 20:16

toluo-stripe added 5 commits January 29, 2025 15:31

LinkAuth abstraction for lookup and signup

7f7c5ae

Replace LinkConfiguration with LinkGate

2d0c064

Add NoLinkAccountFound case

e862846

use startSession

1093950

Fix LinkFormElementTest failures

492e84b

toluo-stripe dismissed amk-stripe’s stale review via 492e84b January 29, 2025 21:09

toluo-stripe force-pushed the tolu/link/link_auth_interface branch from 7b949db to 492e84b Compare January 29, 2025 21:09

amk-stripe approved these changes Jan 29, 2025

View reviewed changes

toluo-stripe merged commit 36d226c into master Jan 29, 2025
13 checks passed

toluo-stripe deleted the tolu/link/link_auth_interface branch January 29, 2025 21:37

toluo-stripe added the Link label Jan 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LinkAuth abstraction for lookup and signup #10019

LinkAuth abstraction for lookup and signup #10019

toluo-stripe commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading

toluo-stripe Jan 28, 2025

amk-stripe Jan 29, 2025

amk-stripe Jan 29, 2025

amk-stripe Jan 29, 2025

amk-stripe Jan 29, 2025

amk-stripe Jan 29, 2025

amk-stripe left a comment

LinkAuth abstraction for lookup and signup #10019

LinkAuth abstraction for lookup and signup #10019

Conversation

toluo-stripe commented Jan 28, 2025 • edited Loading

Summary

Motivation

Testing

github-actions bot commented Jan 28, 2025 • edited Loading

toluo-stripe Jan 28, 2025

Choose a reason for hiding this comment

amk-stripe Jan 29, 2025

Choose a reason for hiding this comment

amk-stripe Jan 29, 2025

Choose a reason for hiding this comment

amk-stripe Jan 29, 2025

Choose a reason for hiding this comment

amk-stripe Jan 29, 2025

Choose a reason for hiding this comment

amk-stripe Jan 29, 2025

Choose a reason for hiding this comment

amk-stripe left a comment

Choose a reason for hiding this comment

toluo-stripe commented Jan 28, 2025 •

edited

Loading

github-actions bot commented Jan 28, 2025 •

edited

Loading