This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Example of carbon / patternfly view switching #141
Open
dlabaj
wants to merge
8
commits into
strimzi:main
Choose a base branch
from
Redhat-AppServices:patternfly
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
620d454
Upgrade to webpack 5
pmuir 4100763
Upgrade html-webpack-plugin to 5.0.0-alpha.14
b1zzu 02cc55e
Merge pull request #1 from b1zzu/upgrade-to-webpack5-pr-79
dlabaj 40c97e9
feat: add module federation
pmuir adae389
Merge pull request #2 from pmuir/module-federation
dlabaj ed08960
fix: export the components better
pmuir de86983
Merge pull request #3 from pmuir/module-federation2
dlabaj fb4d873
Added patternfly and view switching.
dlabaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/* | ||
* Copyright Strimzi authors. | ||
* License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html). | ||
*/ | ||
import { init } from 'i18n'; | ||
import ReactDOM from 'react-dom'; | ||
import React from 'react'; | ||
import { Home } from 'Panels/Home'; | ||
|
||
init(); //Bootstrap i18next support | ||
ReactDOM.render(<Home />, document.getElementById('root')); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1 @@ | ||
/* | ||
* Copyright Strimzi authors. | ||
* License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html). | ||
*/ | ||
import { init } from 'i18n'; | ||
import ReactDOM from 'react-dom'; | ||
import React from 'react'; | ||
import { Home } from 'Panels/Home'; | ||
|
||
init(); //Bootstrap i18next support | ||
ReactDOM.render(<Home />, document.getElementById('root')); | ||
import('./bootstrap'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,5 @@ const Home: FunctionComponent = ({ children }) => { | |
}; | ||
|
||
export { Home }; | ||
|
||
export default Home; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
/* | ||
* Copyright Strimzi authors. | ||
* License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html). | ||
*/ | ||
import { Given, When, Then, Fusion } from 'jest-cucumber-fusion'; | ||
import { render, RenderResult } from '@testing-library/react'; | ||
import { Home } from './Home.patternfly'; | ||
import React, { ReactElement } from 'react'; | ||
|
||
let renderResult: RenderResult; | ||
let component: ReactElement; | ||
|
||
Given('a Home component', () => { | ||
component = <Home />; | ||
}); | ||
|
||
When('it is rendered', () => { | ||
renderResult = render(component); | ||
}); | ||
|
||
Then('it should display text', () => { | ||
const { getByText } = renderResult; | ||
expect(getByText('Welcome to the Strimzi UI for PatternFly')).toBeInTheDocument(); | ||
}); | ||
|
||
Fusion('Home.feature'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/* | ||
* Copyright Strimzi authors. | ||
* License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html). | ||
*/ | ||
import React, { FunctionComponent } from 'react'; | ||
import image from 'Images/logo.png'; | ||
import './style.scss'; | ||
import '@patternfly/react-core/dist/styles/base.css'; | ||
|
||
const Home: FunctionComponent = ({ children }) => { | ||
return ( | ||
<div className='home'> | ||
<img src={image} alt='Strimzi logo' /> | ||
Welcome to the Strimzi UI for PatternFly | ||
{children} | ||
</div> | ||
); | ||
}; | ||
|
||
export { Home }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought
jestModuleMapper
brought in fake file support - will it work if you augment/utils/tooling/aliasHelper.js
to includeless
instead of bringing instyleMock
?