This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
feat: local authentication #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work to be done:
|
PR ReportBundle SizesTest CoverageView test coverage
Triggered by commit: 8d00115 |
nictownsend
force-pushed
the
106-passport-local
branch
from
41a4bee
to
51bbe41
Compare
nictownsend
force-pushed
the
106-passport-local
branch
7 times, most recently
from
faddc8d
to
ef8a510
Compare
matthew-chirgwin
suggested changes
Dec 3, 2020
| Scenario Outline: If assets can be served without authentication, the client module returns the appropriate <StatusCode> return code for a request of <Asset> | ||
| Given a server with a 'client' configuration | ||
| And There are files to serve | ||
| And authentication type 'none' is required |
There was a problem hiding this comment.
Being picky, behaviourally/grammatically, would it be better to have three seperate cases?
- And no authentication of the user is required
- And authentication via an identity provider 'type' of the user is required
- And username/password authentication of the user is required
There was a problem hiding this comment.
I thought I had different scenarios to cover that below?
There was a problem hiding this comment.
Sorry, I was more refering to the definition of the step - does a user care authentication type is none, or that they are/have been authenticated
There was a problem hiding this comment.
My opinion is that in these steps you're a "user" of the server. So you care around the config you have used to create the server.
nictownsend
force-pushed
the
106-passport-local
branch
2 times, most recently
from
f7f6048
to
3a8e903
Compare
| Scenario Outline: If assets can be served without authentication, the client module returns the appropriate <StatusCode> return code for a request of <Asset> | ||
| Given a server with a 'client' configuration | ||
| And There are files to serve | ||
| And authentication type 'none' is required |
There was a problem hiding this comment.
Sorry, I was more refering to the definition of the step - does a user care authentication type is none, or that they are/have been authenticated
nictownsend
force-pushed
the
106-passport-local
branch
from
3a8e903
to
e727fb7
Compare
pmuir
suggested changes
Dec 9, 2020
nictownsend
force-pushed
the
106-passport-local
branch
from
218f644
to
10298e8
Compare
|
@pmuir sorted - they were whitespace changed from linting whole repo instead of staged files |
- introduce passport - add a passport local strategy for authentication - introduce Authentication interface to contain the multiple auth checks (authenticate, checkAuth, logout) - scram router module for authentication, logout, and auth check - no op for no auth - extend auth support to provide additional functions to all modules for checking auth, logging out - remove empty placeholder file Contributes to: strimzi#106 Signed-off-by: Nic Townsend <[email protected]>
nictownsend
force-pushed
the
106-passport-local
branch
from
10298e8
to
479ef00
Compare
This was referenced Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth checks (authenticate, checkAuth, logout)
Contributes to: #106
Signed-off-by: Nic Townsend [email protected]