Add caching of volume observations to mitigate inconsistencies between API calls. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]> Co-authored-by: Robert Young <[email protected]>
Signed-off-by: Sam Barker <[email protected]> Co-authored-by: Robert Young <[email protected]>
Signed-off-by: Sam Barker <[email protected]> Co-authored-by: Robert Young <[email protected]>
Signed-off-by: Sam Barker <[email protected]> Co-authored-by: Robert Young <[email protected]>
Co-authored-by: Robert Young <[email protected]> Signed-off-by: Sam Barker <[email protected]>
Co-authored-by: Robert Young <[email protected]> Signed-off-by: Sam Barker <[email protected]>
Co-authored-by: Robert Young <[email protected]> Signed-off-by: Sam Barker <[email protected]>
tombentley
reviewed
Oct 1, 2023
src/main/java/io/strimzi/kafka/quotas/CachingVolumeObserver.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/kafka/quotas/CachingVolumeObserver.java
Outdated
Show resolved
Hide resolved
| import static org.mockito.Mockito.verify; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class CachingVolumeObserverTest { |
Signed-off-by: Sam Barker <[email protected]>
Also document why we get it and ignore it during `createCacheKey` Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
tombentley
reviewed
Oct 2, 2023
|
Discussed on the Community call on 19.10.2023: @ppatierno will have a look and review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the notion of an observation time to the Volume Usage data and a
CachingVolumeObserverwhich uses that to ensure we maintain valid observations for the configured validity duration.The caching is used to address issues where one set of brokers is returned by the describe cluster API call, however one of those brokers goes offline and is not included in the results of the describe logDirs API call.
This is a limited to solution as it relies on in memory state and thus there remain scenarios where re-starting a broker can lead to problematic throttling decisions. The additional overhead of maintaining shared state between plug-ins in the cluster combined with how unlikely this case is to occur suggests its not worth the effort of addressing that.
Fixes: #40