Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include video posts in art feeds #258

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

KevSlashNull
Copy link
Collaborator

@KevSlashNull KevSlashNull commented Sep 13, 2024

This changes the query to check for has_media and has_video with logical OR, so the default tristate.Maybe is accurate.

For example, right now, if you set HasMedia: tristate.True, HasVideo will implicitly always be tristate.False so no videos will show on that feed.

Before

HasMedia HasVideo Media posts? Video posts? Other posts?
Maybe Maybe
Maybe False
False Maybe
False False
Maybe True
False True
True Maybe
True False
True True

After

HasMedia HasVideo Media posts? Video posts? Other posts?
Maybe Maybe
Maybe False
False Maybe
False False
Maybe True ✅ (change)
False True
True Maybe ✅ (change)
True False
True True

@KevSlashNull KevSlashNull self-assigned this Sep 13, 2024
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bsky-furry-feed-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 8:52pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
bsky-furry-feed-info ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 8:52pm

@strideynet strideynet merged commit fb1c66e into main Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants