Add error message styling #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Looks great! don't forget about the main page where you have to login though.
|
|
@xhayper good call! i’ll take that in a follow up, so i can make the login site a bit more beautiful by e.g. adding the logo and showing an error if you don’t have access. |
xhayper
approved these changes
Aug 21, 2023
strideynet
approved these changes
Aug 21, 2023
|
@strideynet, yeah for sure! Some errors are also still unhandled, like queue actions, which would be easier with TanStack Query. I’ve had it on my todo list for a while now but now there also is #154. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error message types (following #147) and improves their styling, so error messages stand out more and are visibly errors.
cc @xhayper
Screenshots