Merge pull request #1320 from lesichkovm/patch-1

Fix adding ? when no values passed
stretchr · Jul 11, 2023 · af4d8a6 · af4d8a6
2 parents 78aedbf + c029f41
commit af4d8a6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/assert/http_assertions.go b/assert/http_assertions.go
@@ -113,7 +113,10 @@ func HTTPStatusCode(t TestingT, handler http.HandlerFunc, method, url string, va
 // empty string if building a new request fails.
 func HTTPBody(handler http.HandlerFunc, method, url string, values url.Values) string {
 	w := httptest.NewRecorder()
-	req, err := http.NewRequest(method, url+"?"+values.Encode(), nil)
+	if len(values) > 0 {
+		url += "?" + values.Encode()
+	}
+	req, err := http.NewRequest(method, url, nil)
 	if err != nil {
 		return ""
 	}