Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Obtain credentials from request when missing configuration #916

Merged
merged 4 commits into from
Aug 9, 2024
Merged

[API] Obtain credentials from request when missing configuration #916

merged 4 commits into from
Aug 9, 2024

Conversation

MikeEdgar
Copy link
Member

No description provided.

@MikeEdgar MikeEdgar force-pushed the auth-research branch 2 times, most recently from 9fd0f7b to dcda0db Compare July 19, 2024 13:24
@MikeEdgar MikeEdgar force-pushed the auth-research branch 2 times, most recently from 1b9d7f1 to 522fc0e Compare July 31, 2024 23:19
@MikeEdgar MikeEdgar marked this pull request as ready for review August 1, 2024 17:31
@MikeEdgar MikeEdgar force-pushed the auth-research branch 2 times, most recently from 53655cc to 14cd414 Compare August 5, 2024 12:10
@MikeEdgar MikeEdgar requested a review from a team August 5, 2024 16:16
@MikeEdgar MikeEdgar force-pushed the auth-research branch 2 times, most recently from c127b28 to ca40ff3 Compare August 6, 2024 11:40
riccardo-forina
riccardo-forina reviewed Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@riccardo-forina riccardo-forina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still testing this against the UI changes. The SCRAM login works fine, I'm working on the oauth one.

So far so good anyway

@MikeEdgar MikeEdgar force-pushed the auth-research branch 5 times, most recently from 6a41962 to 40688b1 Compare August 9, 2024 11:54
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MikeEdgar MikeEdgar requested a review from a team August 9, 2024 14:32
@MikeEdgar MikeEdgar added this to the 0.3.0 milestone Aug 9, 2024
@MikeEdgar MikeEdgar merged commit 4e1fd8e into main Aug 9, 2024
9 checks passed
@MikeEdgar MikeEdgar deleted the auth-research branch August 9, 2024 14:53
@MikeEdgar MikeEdgar mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardo-forina riccardo-forina riccardo-forina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeEdgar @riccardo-forina