Use KRaft for example install, support node pool storage metrics #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
force-pushed
the
node-pool-storage
branch
from
c68f64b to
e7e824d
Compare
riccardo-forina
approved these changes
Jun 8, 2024
Yes, it's meant to display the storage information for either Zookeeper-based or KRaft-based clusters. Of course the script change for the example install now only uses KRaft. We can keep the ZK variant as well - wdyt? |
MikeEdgar
force-pushed
the
node-pool-storage
branch
from
e7e824d to
d4ec3c0
Compare
Signed-off-by: Michael Edgar <[email protected]>
MikeEdgar
force-pushed
the
node-pool-storage
branch
from
d4ec3c0 to
b2cc560
Compare
|
I've added back a way to run the Kafka cluster with ZK (additional script argument) and this is mentioned now in the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Strimzi KafkaNodePools [1] (required to run the cluster in KRaft mode), storage metrics have a slightly different format for the PVC label. This PR adds support for storage allocated via a node pool, and also changes the example Kafka cluster to use KRaft mode.
[1] https://strimzi.io/blog/2023/08/28/kafka-node-pools-storage-and-scheduling/