Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-platform images #734

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Multi-platform images #734

merged 1 commit into from
Jul 2, 2024

Conversation

MikeEdgar
Copy link
Member

No description provided.

@MikeEdgar
Copy link
Member Author

@riccardo-forina you're expecting linux/arm64 images for running on MacOS right?

@riccardo-forina
Copy link
Collaborator

Yes thank you!

@riccardo-forina
Copy link
Collaborator

Will this tag the console-api image as latest as well as the ui one? By the way, wouldn't it make sense to have the ui image be called console-ui for consistency with the api one?

@MikeEdgar
Copy link
Member Author

Will this tag the console-api image as latest as well as the ui one? By the way, wouldn't it make sense to have the ui image be called console-ui for consistency with the api one?

It's so far just building the images in the test CI and not yet in the release job. I agree we should use console-ui for the image name. I'll make that change here as well. It would also be good to add a new job that builds the images on each commit to main and push a main tag into quay.io.

@MikeEdgar MikeEdgar added this to the 0.0.36 milestone May 20, 2024
@MikeEdgar MikeEdgar marked this pull request as ready for review May 20, 2024 17:18
@MikeEdgar
Copy link
Member Author

@riccardo-forina , the ARM build seems to be quite slow. The output of npm run build isn't architecture-specific is it? If it is not, maybe the build could be re-factored somehow.

@riccardo-forina
Copy link
Collaborator

Uhm I don't think it is. I don't do anything fancy on the Mac to build the app

@MikeEdgar MikeEdgar removed this from the 0.0.36 milestone May 21, 2024
@MikeEdgar MikeEdgar marked this pull request as draft June 5, 2024 12:24
@MikeEdgar MikeEdgar marked this pull request as draft June 5, 2024 12:24
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MikeEdgar MikeEdgar force-pushed the multiarch branch 2 times, most recently from 4a05ecd to 436253c Compare June 27, 2024 16:48
@MikeEdgar MikeEdgar marked this pull request as ready for review June 27, 2024 16:49
@MikeEdgar MikeEdgar added this to the 0.1.2 milestone Jun 27, 2024
Signed-off-by: Michael Edgar <[email protected]>
Copy link

sonarqubecloud bot commented Jul 2, 2024

@MikeEdgar MikeEdgar merged commit 04c3cc0 into main Jul 2, 2024
9 checks passed
@MikeEdgar MikeEdgar deleted the multiarch branch July 2, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants