Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustments to install resources for domain alignment, envs #673

Merged
merged 2 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions install/003-install-console.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ CONSOLE_INSTALL_PATH="$(cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P)"
RESOURCE_PATH=${CONSOLE_INSTALL_PATH}/resources

export NAMESPACE="${1?Please provide the deployment namespace}"
export CLUSTER_DOMAIN="${2?Please provide the base domain name for Kafka listener ingress}"

source ${CONSOLE_INSTALL_PATH}/_common.sh

Expand Down
6 changes: 5 additions & 1 deletion install/resources/console/console.deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ spec:
value: ${NAMESPACE}/console-kafka
- name: CONSOLE_KAFKA_EXAMPLE_BOOTSTRAP_SERVERS
# Replace with your Kafka's boostrap address
value: bootstrap.console-kafka.apps-crc.testing:443
value: bootstrap.console-kafka.${CLUSTER_DOMAIN}:443
- name: CONSOLE_KAFKA_EXAMPLE_SASL_JAAS_CONFIG
valueFrom:
secretKeyRef:
Expand Down Expand Up @@ -62,5 +62,9 @@ spec:
value: 'http://127.0.0.1:8080'
- name: CONSOLE_METRICS_PROMETHEUS_URL
value: 'http://prometheus-operated.${NAMESPACE}.svc.cluster.local:9090'
- name: CONSOLE_MODE
value: read-only
- name: LOG_LEVEL
value: info
Comment on lines +65 to +68
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are needed until 0.0.34 is released

ports:
- containerPort: 3000
Loading