Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate missing metrics, use alternate metric from replica count #475

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Tolerate missing metrics, use alternate metric from replica count #475

merged 1 commit into from
Feb 14, 2024

Conversation

MikeEdgar
Copy link
Member

  1. Make the UI a bit more tolerant of missing metric values which may not be available in Prometheus early in the deployment.
  2. Using kafka_server_replicamanager_partitioncount [1] for the number of partition replicas on each broker.
    Before:
    image
    After:
    image

[1] https://www.ibm.com/docs/en/instana-observability/current?topic=technologies-monitoring-kafka#partitions

@MikeEdgar MikeEdgar added this to the 0.0.26 milestone Feb 14, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MikeEdgar MikeEdgar merged commit cbf691d into main Feb 14, 2024
7 checks passed
@MikeEdgar MikeEdgar deleted the metrics-tolerate-missing-vals branch February 14, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardo-forina riccardo-forina riccardo-forina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.26
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeEdgar @riccardo-forina