-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to filter topics by status #280
Conversation
riccardo-forina
commented
Dec 19, 2023
•
edited
Loading
edited
ui/api/topics/actions.ts
Outdated
@@ -38,6 +40,7 @@ export async function getTopics( | |||
"name,status,visibility,numPartitions,totalLeaderLogBytes,consumerGroups", | |||
"filter[id]": params.id ? `eq,${params.id}` : undefined, | |||
"filter[name]": params.name ? `like,*${params.name}*` : undefined, | |||
"filter[status]": params.status, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case where there is no "operator" in the filter like eq
or in
, the API defaults to eq
. If you ever want to search for multiple status values, the in
could be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it wasn't clear from the openapi doc, I thought it supported a single value only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I missed docs for many of the filter
parameters. They should all follow that pattern. I'll see if there's a nice way to document that without too much repetition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, updated screens in the PR description to match the new option
Quality Gate passedKudos, no new issues were introduced! 0 New issues |