-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic and partition statuses #219
Conversation
28474a5
to
2fdf204
Compare
40fef84
to
f0c77cd
Compare
2fdf204
to
8f3a5ee
Compare
f0c77cd
to
80e48ca
Compare
bf682a2
to
2b8eb01
Compare
Signed-off-by: Michael Edgar <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
cc1c50c
to
50d34b5
Compare
Signed-off-by: Michael Edgar <[email protected]>
f042f48
to
95eb305
Compare
Signed-off-by: Michael Edgar <[email protected]>
95eb305
to
79d143e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this and for changing the to bits as well!
I left a single question, but LGTM
Signed-off-by: Michael Edgar <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
|
The individual status codes for each partition are available in the response from the backend API, so I think this could be done. << @riccardo-forina w.d.y.t?
That makes sense, any change in icon?
This should be fine, we can add this along with the other planned tooltips 👍 |
See the example for the number of under-replicated https://miro.com/app/board/uXjVNbMAIcU=/?moveToWidget=3458764572936405853&cot=14. we can also address this in the mockup doc for prioritization if it is not trivial to implement. Yes, the icon should be: |
Some initial experimentation with topic/partition statuses and handling offline partitions. PR targets #171 , but will be updated to
main
later.Offline
: leader is missingOffline
: all partitionsOffline
PartiallyOffline
: hasOffline
partitionsUnderReplicated
: has out-of-sync replicaUnderReplicated
: hasUnderReplicated
partitionsFullyReplicated
FullyReplicated
Because the Admin client cannot fetch offsets for any partition of a topic where any of the partitions are offline, the API will not attempt to do so for
Offline
orPartiallyOffline
topics. Similarly, replicalocalStorage
will only be fetched for online partitions.With one broker stopped:

Topic

a_3
with replication factor of 1 has no leader (i.e. offline)Broker restarted:
