Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add endpoint to patch Kafka resource pause annotation #1103

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

MikeEdgar
Copy link
Member

Add endpoint to patch Kafka resource pause annotation. When the paused annotation is present on the Kafka CR, the kafka resource returned by the API will include a .meta.reconciliationPaused boolean flag that is true or false, depending on the annotation value. Otherwise, if there is no annotation on the Cr, the .meta.reconciliationPaused will not be present.

@MikeEdgar MikeEdgar added this to the 0.4.0 milestone Oct 7, 2024
@MikeEdgar
Copy link
Member Author

@hemahg - these are the API changes to pause/resume the Kafka resource reconciliation.

@MikeEdgar MikeEdgar force-pushed the kafkas-patch-paused-annotation branch 4 times, most recently from c38e3d8 to 34e6eb9 Compare October 14, 2024 13:50
@MikeEdgar MikeEdgar force-pushed the kafkas-patch-paused-annotation branch 2 times, most recently from d9028c8 to e139f81 Compare October 16, 2024 13:53
@MikeEdgar MikeEdgar force-pushed the kafkas-patch-paused-annotation branch from e139f81 to cc67303 Compare October 16, 2024 14:17
Copy link

@MikeEdgar MikeEdgar requested a review from a team October 16, 2024 15:43
Copy link
Contributor

@hemahg hemahg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @MikeEdgar, everything was working as expected

@MikeEdgar MikeEdgar merged commit ae2b12e into main Oct 16, 2024
9 checks passed
@MikeEdgar MikeEdgar deleted the kafkas-patch-paused-annotation branch October 16, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants