Refactor the feature flags

streamshub · Jun 14, 2024 · bf7e240 · bf7e240
1 parent 90bdbb9
commit bf7e240
Show file tree

Hide file tree

Showing 15 changed files with 259 additions and 203 deletions.
diff --git a/ui/app/[locale]/AppLayout.tsx b/ui/app/[locale]/AppLayout.tsx
@@ -19,7 +19,10 @@ import { HelpIcon } from "@/libs/patternfly/react-icons";
 import { useTranslations } from "next-intl";
 import { PropsWithChildren, Suspense } from "react";
 
-export function AppLayout({ children }: PropsWithChildren) {
+export function AppLayout({
+  children,
+  showLearningLinks,
+}: PropsWithChildren<{ showLearningLinks: boolean }>) {
   const t = useTranslations();
   return (
     <Page
@@ -45,7 +48,7 @@ export function AppLayout({ children }: PropsWithChildren) {
     >
       {/*<HelpContainer>*/}
       <ClusterDrawerProvider>
-        <ClusterDrawer>
+        <ClusterDrawer showLearningLinks={showLearningLinks}>
           <Banner variant={"blue"}>
             <Split>
               <SplitItem isFilled={true}>

diff --git a/ui/app/[locale]/ClusterConnectionDetails.tsx b/ui/app/[locale]/ClusterConnectionDetails.tsx
@@ -11,12 +11,13 @@ import {
 } from "@/libs/patternfly/react-core";
 import { Divider, Stack, StackItem } from "@patternfly/react-core";
 import { useTranslations } from "next-intl";
-import { enabled as learningLinksEnabled } from "@/utils/learningLinks";
 
 export async function ClusterConnectionDetails({
   clusterId,
+  showLearningLinks,
 }: {
   clusterId: string;
+  showLearningLinks: boolean;
 }) {
   const t = useTranslations();
   const data = await getKafkaCluster(clusterId);
@@ -102,25 +103,33 @@ export async function ClusterConnectionDetails({
           </ExpandableSection>
         </TextContent>
       </StackItem>
-      { learningLinksEnabled() &&
-      <StackItem>
-        <Divider />
-        <Stack hasGutter={true} className={"pf-v5-u-p-lg"}>
-          { t("learning.links.connecting") &&
-          <StackItem>
-            <ExternalLink testId={"drawer-footer-help-1"} href={t("learning.links.connecting")}>
-              {t("ClusterConnectionDetails.developing_kafka_client_applications",)}
-            </ExternalLink>
-          </StackItem>
-          }
-          <StackItem>
-            <ExternalLink testId={"drawer-footer-help-1"} href={t("learning.links.overview")}>
-              {t("ClusterConnectionDetails.streams_portal")}
-            </ExternalLink>
-          </StackItem>
-        </Stack>
-      </StackItem>
-      }
+      {showLearningLinks && (
+        <StackItem>
+          <Divider />
+          <Stack hasGutter={true} className={"pf-v5-u-p-lg"}>
+            {t("learning.links.connecting") && (
+              <StackItem>
+                <ExternalLink
+                  testId={"drawer-footer-help-1"}
+                  href={t("learning.links.connecting")}
+                >
+                  {t(
+                    "ClusterConnectionDetails.developing_kafka_client_applications",
+                  )}
+                </ExternalLink>
+              </StackItem>
+            )}
+            <StackItem>
+              <ExternalLink
+                testId={"drawer-footer-help-1"}
+                href={t("learning.links.overview")}
+              >
+                {t("ClusterConnectionDetails.streams_portal")}
+              </ExternalLink>
+            </StackItem>
+          </Stack>
+        </StackItem>
+      )}
     </Stack>
   );
 }
diff --git a/ui/app/[locale]/ClusterDrawer.tsx b/ui/app/[locale]/ClusterDrawer.tsx
@@ -16,7 +16,10 @@ import { Skeleton } from "@patternfly/react-core";
 import { useTranslations } from "next-intl";
 import { PropsWithChildren, Suspense } from "react";
 
-export function ClusterDrawer({ children }: PropsWithChildren) {
+export function ClusterDrawer({
+  children,
+  showLearningLinks,
+}: PropsWithChildren<{ showLearningLinks: boolean }>) {
   const t = useTranslations();
   const { expanded, clusterId, close } = useClusterDrawerContext();
   return (
@@ -48,7 +51,12 @@ export function ClusterDrawer({ children }: PropsWithChildren) {
                 </div>
               }
             >
-              {clusterId && <ClusterConnectionDetails clusterId={clusterId} />}
+              {clusterId && (
+                <ClusterConnectionDetails
+                  clusterId={clusterId}
+                  showLearningLinks={showLearningLinks}
+                />
+              )}
             </Suspense>
           </DrawerPanelContent>
         }