Fix null pointer exception

Signed-off-by: Michael Edgar <[email protected]>
streamshub · Oct 18, 2024 · 7b08738 · 7b08738
1 parent 7ca2a07
commit 7b08738
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/api/src/main/java/com/github/streamshub/console/api/model/Topic.java b/api/src/main/java/com/github/streamshub/console/api/model/Topic.java
@@ -193,6 +193,10 @@ public String visibility() {
         @JsonProperty
         @Schema(readOnly = true, description = "The number of partitions in this topic")
         public Integer numPartitions() {
+            if (partitions == null) {
+                return null;
+            }
+
             return partitions.getOptionalPrimary().map(Collection::size).orElse(0);
         }
 

diff --git a/api/src/main/java/com/github/streamshub/console/api/service/TopicService.java b/api/src/main/java/com/github/streamshub/console/api/service/TopicService.java
@@ -190,7 +190,13 @@ public CompletionStage<List<Topic>> listTopics(List<String> fields, String offse
 
     Topic tallySummary(Map<String, Integer> statuses, AtomicInteger partitionCount, Topic topic) {
         statuses.compute(topic.status(), (k, v) -> v == null ? 1 : v + 1);
-        partitionCount.addAndGet(topic.getAttributes().numPartitions());
+
+        Integer numPartitions = topic.getAttributes().numPartitions();
+        //numPartitions may be null if it was not included in the requested fields
+        if (numPartitions != null) {
+            partitionCount.addAndGet(numPartitions);
+        }
+
         return topic;
     }