Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(network): Default configs as constants for layer2 #2997

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

juslesan
Copy link
Contributor

@juslesan juslesan commented Jan 29, 2025

Summary

Added constants for default configurations for Layer2 classes.

Changes

  • Random node view count is now configured with the nodeViewSize config option

Future improvements

  • Do the same for the discovery layer refactor(network): Default configuration constants for DiscoveryLayerNode #3000
  • Remove remaining magic numbers around ControlLayerNode configuration (Could also clean up on the DHT side).
  • Could maybe pass some of the defaults from a higher layer (for example the sdk). This will require some thought as some of the configs could be wanted on a per stream partition basis and others for all streams.
  • Rename all fields with listSize to ie listNodeCount

@github-actions github-actions bot added the network Related to Network Package label Jan 29, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@juslesan juslesan force-pushed the layer2-config-defaults branch from f34c905 to 779d518 Compare January 29, 2025 14:07
@juslesan juslesan requested review from teogeb and harbu January 30, 2025 12:55
@juslesan juslesan marked this pull request as ready for review January 30, 2025 12:55
Copy link
Contributor

@harbu harbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juslesan juslesan merged commit 7edd548 into main Mar 4, 2025
24 checks passed
@juslesan juslesan deleted the layer2-config-defaults branch March 4, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network Related to Network Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants