Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONT-1872] Make connection drawing smarter #353

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[FRONT-1872] Make connection drawing smarter #353

merged 1 commit into from
Jan 31, 2025

Conversation

tumppi
Copy link
Contributor

@tumppi tumppi commented Nov 8, 2024

I enhanced connection visibility logic to show connections when:

  • ConnectionsMode is Always, OR
  • A stream is selected, OR
  • A node is selected

I also added visual feedback for connection toggle button (blue when active) and optimized useNodeConnections hook with early returns and proper dependency tracking.

@linear Linear
Copy link

linear bot commented Nov 8, 2024

FRONT-1872 Make connections drawing smarter

@tumppi tumppi requested a review from mondoreale November 8, 2024 08:50
mondoreale
mondoreale approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@mondoreale mondoreale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@tumppi tumppi merged commit 5fe7463 into master Jan 31, 2025
3 checks passed
@tumppi tumppi deleted the FRONT-1872-connection-drawing branch January 31, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondoreale mondoreale mondoreale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tumppi @mondoreale