Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken links in GCP vendor-access module README #69

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Feb 14, 2024

fixes #70

Modifications

  1. docs link: fixed to latest version
  2. resource links: define template to handle these two special cases
    • project_iam_member: The doc of this resource is organized under another resource
    • google_project_service: The prefix "google" was removed by terraform_docs. This should be correct for another modules, but the google module reserve the prefix for all resources.
  3. After this PR, we should update README content in .config/.terraform-docs.yml, then execute terraform-docs markdown . > README.md to generate the updated README file. This can be integrated into pre-commit hooks.

@ciiiii ciiiii requested a review from a team as a code owner February 14, 2024 00:28
@ciiiii ciiiii changed the title chore: Fix broken links in GCP vendor-access module README docs: Fix broken links in GCP vendor-access module README Feb 14, 2024
@ciiiii ciiiii merged commit 861f80e into main Feb 16, 2024
8 checks passed
@ciiiii ciiiii deleted the yscai/fix-broken-link branch February 16, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links in GCP vendor-access module README
3 participants