Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add KMS Uniqueness #51

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: Add KMS Uniqueness #51

merged 1 commit into from
Jun 7, 2024

Conversation

mitch-hamm
Copy link
Contributor

Use cluster name in key for customers with multiple clusters in a project

@mitch-hamm mitch-hamm requested a review from a team as a code owner June 5, 2024 21:17
@mitch-hamm mitch-hamm changed the title Add KMS Uniqueness fix: Add KMS Uniqueness Jun 5, 2024
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this affect existing customer after this rollout?

since the name change will cause destroy existing resource and do replace.

@mitch-hamm
Copy link
Contributor Author

How will this affect existing customer after this rollout?

since the name change will cause destroy existing resource and do replace.

@maxsxu Yes, we have a separate PR to disable this for the 1 customer using it in test. Then this will be merged, then we'll re-enable for that customer

@mitch-hamm mitch-hamm merged commit 39e9bc3 into master Jun 7, 2024
4 checks passed
@mitch-hamm mitch-hamm deleted the mh/gke-key-change branch June 7, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants