Add test for the partitionKey with other operation #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zymap
requested review from
merlimat,
mattisonchao,
coderzc and
RobertIndie
as code owners
|
|
It seems it has this issue on the ComparisonCeiling and ComparisonHigher |
zymap
force-pushed
the
opeartion-with-partition-key
branch
from
1eeacc1
to
0e42e81
Compare
merlimat
reviewed
May 23, 2024
| SyncOxiaClient client = OxiaClientBuilder.create(oxia.getServiceAddress()).syncClient(); | ||
|
|
||
|
|
||
| GetResult gr = client.get("a", Set.of(GetOption.PartitionKey("a"), GetOption.ComparisonCeiling)); |
There was a problem hiding this comment.
These keys were added by previous tests and might or might not have the partition-key set. Therefore, the routing to a shard could be different.
Take a look at https://github.com/streamnative/oxia-java/blob/main/client/src/main/java/io/streamnative/oxia/client/AsyncOxiaClientImpl.java#L480-L486 to see how passing a partition-key changes the Get operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.