Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[fix] Run messageReadStats metrics registerFailedEvent execute on netty threa… #2007

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

zhouxy0809
Copy link
Contributor

Fix: follow to #2006

Motivation

the metric of messageReadStats.registerFailedEvent() not execute in netty thread executor, and not consistent with context code

Modifications

*execute messageReadStats.registerFailedEvent() in netty.EventExecutor *

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2007 (1a808ad) into master (014340d) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2007      +/-   ##
============================================
+ Coverage     16.95%   16.96%   +0.01%     
- Complexity      728      729       +1     
============================================
  Files           191      191              
  Lines         14307    14309       +2     
  Branches       1339     1339              
============================================
+ Hits           2426     2428       +2     
- Misses        11703    11704       +1     
+ Partials        178      177       -1     
Files Changed Coverage Δ
...tive/pulsar/handlers/kop/storage/PartitionLog.java 8.13% <0.00%> (-0.03%) ⬇️

... and 1 file with indirect coverage changes

@BewareMyPower BewareMyPower merged commit db4a9ad into streamnative:master Oct 8, 2023
19 of 20 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants