[transactions] Prevent NullPointerException due to Recycled object used in different threads #1919
Conversation
…ed in different threads
|
Yiming Zang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@yzang2019:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
|
@yzang2019:Thanks for providing doc info! |
github-actions
bot
added
no-need-doc
|
@yzang2019:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-info-missing
|
@yzang2019:Thanks for providing doc info! |
| context.startSendOperationForThrottling = startSendOperationForThrottling; | ||
| context.completeSendOperationForThrottling = completeSendOperationForThrottling; | ||
| context.pendingTopicFuturesMap = pendingTopicFuturesMap; | ||
| context.topicManager = topicManager; | ||
| context.ctx = ctx; | ||
|
|
||
| return context; | ||
| } | ||
|
|
||
| public void recycle() { |
There was a problem hiding this comment.
I think they are removed recycle method in this commit: datastax/starlight-for-kafka@0b6fd77
There was a problem hiding this comment.
Good call, then it's probably not needed any more
Motivation
Cherry pick changes in datastax/starlight-for-kafka@e85e4c2
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)