This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[transactions] Better handling of network exceptions while sending TX markers #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
============================================
- Coverage 18.76% 18.33% -0.44%
- Complexity 742 743 +1
============================================
Files 185 190 +5
Lines 13266 13605 +339
Branches 1213 1260 +47
============================================
+ Hits 2490 2494 +4
- Misses 10594 10930 +336
+ Partials 182 181 -1
|
|
@gaoran10 @BewareMyPower @yzang2019 Please help review this PR : ) |
BewareMyPower
suggested changes
Jun 26, 2023
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
...java/io/streamnative/pulsar/handlers/kop/coordinator/transaction/TransactionCoordinator.java
Show resolved
Hide resolved
BewareMyPower
approved these changes
Jun 26, 2023
gaoran10
approved these changes
Jun 26, 2023
Demogorgon314
deleted the
s4k/Better_handling_of_network_exceptions_while_sending_TX_markers
branch
BewareMyPower
pushed a commit
that referenced
this pull request
Jun 29, 2023
… markers (#1907) This PR is cherry-picking from datastax/starlight-for-kafka@e0636995 ### Motivation Complete the pending request features when the channel is Inactive, or the exception caught. Co-authored-by: Enrico Olivelli <[email protected]> (cherry picked from commit 8287e60)
BewareMyPower
pushed a commit
that referenced
this pull request
Jul 3, 2023
… markers (#1907) This PR is cherry-picking from datastax/starlight-for-kafka@e0636995 ### Motivation Complete the pending request features when the channel is Inactive, or the exception caught. Co-authored-by: Enrico Olivelli <[email protected]> (cherry picked from commit 8287e60)
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Aug 14, 2023
… markers (streamnative#1907) This PR is cherry-picking from datastax/starlight-for-kafka@e0636995 ### Motivation Complete the pending request features when the channel is Inactive, or the exception caught. Co-authored-by: Enrico Olivelli <[email protected]> (cherry picked from commit 8287e60)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cherry-picking from datastax/starlight-for-kafka@e0636995
Motivation
Complete the pending request features when the channel is Inactive, or the exception caught.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)