Rename "GC Pauses" to "GC Time" in Pulsar JVM dashboards¬ #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- source metric is not about GC pauses.¬ - the source metric is "jvm_gc_collection_seconds_sum" which is not the same as "GC pause"¬ - The metric is defined in Prometheus Java client¬ - "Time spent in a given JVM garbage collector in seconds."¬ - source code is https://github.com/prometheus/client_java/blob/e68daf23336eb5de7856df406eb1d497f51ad3be/simpleclient_hotspot/src/main/java/io/prometheus/client/hotspot/GarbageCollectorExports.java#L53¬ - calls GarbageCollectorMXBean.getCollectionTime()¬ - Javadoc https://docs.oracle.com/en/java/javase/11/docs/api/java.management/java/lang/management/GarbageCollectorMXBean.html#getCollectionTime()¬ "Returns the approximate accumulated collection elapsed time in milliseconds."¬ - Stackoverflow Q&A: https://stackoverflow.com/a/44686539¬
lhotari
force-pushed
the
lh-rename-gc-pauses-to-collection-time
branch
from
5cf67d0
to
b9488c0
Compare
lhotari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Returns the approximate accumulated collection elapsed time in milliseconds."¬