Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump windows-core to 0.53-0.54 range #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarijnS95
Copy link
Contributor

This includes the necessary binding changes for compatibility, provided by windows-bindgen 0.53-0.54. Generated code by windows-bindgen now also expects TryInto to be in scope via Rust's prelude, which is only the case in Rust edition 2021.

This includes the necessary binding changes for compatibility, provided
by `windows-bindgen 0.53-0.54`.  Generated code by `windows-bindgen`
now also expects `TryInto` to be in scope via Rust's `prelude`, which is
only the case in Rust edition `2021`.
MarijnS95 added a commit to MarijnS95/iana-time-zone that referenced this pull request Mar 26, 2024
Note that `windows 0.55` was not released, and any implementation in
the wild depending on `windows` will get `windows-core 0.54` in their
dependency tree for obvious compatibility reasons, and would get a
duplicate if `iana-time-zone` decides to switch to o`windows-core 0.55`
prematurely. This PR depends on strawlab#131 and can be updated and merged
whenever there is a compelling reason to bump further.

This requires a strange change to remove a "comment" from `bindings.txt`:

              Running `api_gen/target/debug/api_gen`
         Error: Error { message: "unused filters\n  Dependencies\n  above\n  the\n  of\n  #", path: "", span: None }
MarijnS95 added a commit to MarijnS95/iana-time-zone that referenced this pull request Mar 26, 2024
Note that `windows 0.55` was not released, and any implementation in
the wild depending on `windows` will get `windows-core 0.54` in their
dependency tree for obvious compatibility reasons, and would get a
duplicate if `iana-time-zone` decides to switch to o`windows-core 0.55`
prematurely. This PR depends on strawlab#131 and can be updated and merged
whenever there is a compelling reason to bump further.

This requires a strange change to remove a "comment" from `bindings.txt`:

         Running `api_gen/target/debug/api_gen`
    Error: Error { message: "unused filters\n  Dependencies\n  above\n  the\n  of\n  #", path: "", span: None }
@MarijnS95
Copy link
Contributor Author

Bumping the edition for having TryInto in the prelude will break MSRV, let's see if we can find a way around that.

@MarijnS95
Copy link
Contributor Author

@astraw I don't see any strategy as to what the policy is regarding MSRV bumps in https://github.com/strawlab/iana-time-zone?tab=readme-ov-file#minimum-supported-rust-version-policy, and it seems likely that an internal version bump for a newer crate that doesn't provide any useful/fixed functionality otherwise (besides getting rid of duplicate deps downstream) isn't very compelling to break MSRV for. Despite that, what are your thoughts? The requested version here for windows 0.53 is Rust 1.62.

@Kijewski Kijewski added dependencies Pull requests that update a dependency file Tier-1 Rust Tier-1 platform labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Tier-1 Rust Tier-1 platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants