chore(ruff): Enable and fix all ruff rules that we can #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request enables and fixes all applicable ruff rules, improving code style and maintainability. Some rules are ignored inline with "# noqa " where necessary, particularly in tests, to accommodate specific use cases. Class diagram showing key changes to error handling patternsclassDiagram
class BaseException {
+message: str
+raise_from(cause: Exception)
}
class CustomError {
+message: str
+__init__(message: str)
}
class ErrorWithPayload {
+payload: dict
+__init__(payload: dict)
}
BaseException <|-- CustomError
BaseException <|-- ErrorWithPayload
note for CustomError "Changed to use raise from pattern"
note for ErrorWithPayload "Changed to use None default for payload"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Apollo Federation Subgraph Compatibility Results
Learn more: |
|
Hi, thanks for contributing to Strawberry 🍓! We noticed that this PR is missing a So as soon as this PR is merged, a release will be made 🚀. Here's an example of Release type: patch
Description of the changes, ideally with some examples, if adding a new feature.Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :) Here's the tweet text: |
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
- Coverage 97.32% 97.28% -0.04%
==========================================
Files 501 502 +1
Lines 33386 33375 -11
Branches 5478 5477 -1
==========================================
- Hits 32493 32469 -24
- Misses 685 697 +12
- Partials 208 209 +1 |
CodSpeed Performance ReportMerging #3742 will not alter performanceComparing Summary
|
bellini666
force-pushed
the
ruff_rules
branch
from
b9c0e39 to
275148b
Compare
patrick91
reviewed
Dec 26, 2024
erikwrede
reviewed
Dec 26, 2024
erikwrede
reviewed
Dec 28, 2024
| @@ -88,7 +87,6 @@ def get_type_by_name( | |||
| raise NotImplementedError | |||
|
|
|||
| @abstractmethod | |||
| @lru_cache | |||
There was a problem hiding this comment.
just flagging this to come back & check the children later
|
@patrick91 @erikwrede thank you for the careful review :) (the PR is large lol) I reverted the changes for the rules that we don't want in the codebase and added them to the ignore list. Let me know if there's anything else you want me to revert here |
erikwrede
approved these changes
Dec 30, 2024
patrick91
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through all ruff rules we were ignoring and enabled all that made sense.
Some have legit use cases in some places, so I changed to an inline "# noqa " instead of having to disable those for the whole file. Some still made sense to be ignored on tests.
Summary by Sourcery
Enable more Ruff rules and fix existing violations.