chore(ruff): Enable ignored UP rules #3741

bellini666 · 2024-12-25T15:10:51Z

Was testing enabling some ruff rules and this one was able to fix itself completly with check --fix

Personally I do prefer X | Y instead of Union[X, Y] and X | None instead of Optional[X], but I'm not sure if there would be any unwanted consequences in doing this?

Summary by Sourcery

Chores:

Replace Union[X, Y] with X | Y and Optional[X] with X | None.

sourcery-ai · 2024-12-25T15:10:56Z

Reviewer's Guide by Sourcery

This pull request refactors the codebase to use the pipe operator | instead of Union and Optional for type hinting.

Class diagram showing type hint changes

classDiagram
    class TypeHints {
        Before
        +Optional[str]
        +Union[X, Y]
        +Optional[list[type[BasePermission]]]
        +Union[Callable[..., object], object]
        After
        +str | None
        +X | Y
        +list[type[BasePermission]] | None
        +Callable[..., object] | object
    }
    note for TypeHints "Changes in type hint syntax
Moving from Union/Optional to | operator"

File-Level Changes

Change	Details	Files
Replaced Union and Optional type hints with the pipe operator.	Used the pipe operator `	`for optional types instead of`Optional[X]`.</li><li>Used the pipe operator`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

for more information, see https://pre-commit.ci

sourcery-ai

Hey @bellini666 - I've reviewed your changes and they look great!

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

sourcery-ai · 2024-12-25T15:12:51Z

strawberry/experimental/pydantic/utils.py

@@ -70,7 +69,7 @@ def to_tuple(self) -> tuple[str, type, dataclasses.Field]:
 def get_default_factory_for_field(
    field: CompatModelField,


issue (code-quality): We've found these issues:

Hoist a repeated condition into a parent condition (hoist-repeated-if-condition)

Swap positions of nested conditionals (swap-nested-ifs)

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

Hoist nested repeated code outside conditional statements (hoist-similar-statement-from-if)

sourcery-ai · 2024-12-25T15:12:51Z

tests/http/clients/fastapi.py

@@ -114,10 +114,10 @@ async def _handle_response(self, response: Any) -> Response:
    async def _graphql_request(
        self,
        method: Literal["get", "post"],


issue (code-quality): We've found these issues:

Use named expression to simplify assignment and conditional (use-named-expression)

Merge else clause's nested if statement into elif (merge-else-if-into-elif)

sourcery-ai · 2024-12-25T15:12:51Z

tests/http/clients/sanic.py

@@ -74,10 +74,10 @@ def __init__(
    async def _graphql_request(
        self,
        method: Literal["get", "post"],


issue (code-quality): We've found these issues:

Use named expression to simplify assignment and conditional (use-named-expression)

Merge else clause's nested if statement into elif (merge-else-if-into-elif)

botberry · 2024-12-25T15:13:01Z

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support

`_service`	🟢
`@key (single)`	🟢
`@key (multi)`	🟢
`@key (composite)`	🟢
`repeatable @key`	🟢
`@requires`	🟢
`@provides`	🟢
`federated tracing`	🔲

`@link`	🟢
`@shareable`	🟢
`@tag`	🟢
`@override`	🟢
`@inaccessible`	🟢
`@composeDirective`	🟢
`@interfaceObject`	🟢

Learn more:

botberry · 2024-12-25T15:13:11Z

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

botberry · 2024-12-25T15:13:12Z

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

bellini666 · 2024-12-25T15:15:17Z

Apparently we can enable this next year, after we drop support for 3.9 =P

codspeed-hq · 2024-12-25T15:23:54Z

CodSpeed Performance Report

Merging #3741 will not alter performance

_{Comparing ruff_up_rule (1f2ad37) with main (e78f8c6)}

Summary

✅ 21 untouched benchmarks

codecov · 2024-12-25T21:12:09Z

Codecov Report

Attention: Patch coverage is 96.56250% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (e78f8c6) to head (1f2ad37).

❗ There is a different number of reports uploaded between BASE (e78f8c6) and HEAD (1f2ad37). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (e78f8c6) HEAD (1f2ad37)

2 1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3741       +/-   ##
===========================================
- Coverage   97.27%   72.29%   -24.99%     
===========================================
  Files         501      496        -5     
  Lines       33408    32245     -1163     
  Branches     5480     1663     -3817     
===========================================
- Hits        32499    23310     -9189     
- Misses        701     8665     +7964     
- Partials      208      270       +62

chore(ruff): Enable ignored UP rules

c79acee

bellini666 self-assigned this Dec 25, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

1f2ad37

for more information, see https://pre-commit.ci

sourcery-ai bot reviewed Dec 25, 2024

View reviewed changes

bellini666 closed this Dec 25, 2024

bellini666 deleted the ruff_up_rule branch December 25, 2024 15:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ruff): Enable ignored UP rules #3741

chore(ruff): Enable ignored UP rules #3741

bellini666 commented Dec 25, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Dec 25, 2024 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

sourcery-ai bot Dec 25, 2024

sourcery-ai bot Dec 25, 2024

sourcery-ai bot Dec 25, 2024

botberry commented Dec 25, 2024

botberry commented Dec 25, 2024

botberry commented Dec 25, 2024

bellini666 commented Dec 25, 2024

codspeed-hq bot commented Dec 25, 2024

codecov bot commented Dec 25, 2024

		@@ -70,7 +69,7 @@ def to_tuple(self) -> tuple[str, type, dataclasses.Field]:
		def get_default_factory_for_field(
		field: CompatModelField,

chore(ruff): Enable ignored UP rules #3741

chore(ruff): Enable ignored UP rules #3741

Conversation

bellini666 commented Dec 25, 2024 • edited by sourcery-ai bot Loading

Summary by Sourcery

sourcery-ai bot commented Dec 25, 2024 • edited Loading

Reviewer's Guide by Sourcery

Class diagram showing type hint changes

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

sourcery-ai bot Dec 25, 2024

Choose a reason for hiding this comment

sourcery-ai bot Dec 25, 2024

Choose a reason for hiding this comment

sourcery-ai bot Dec 25, 2024

Choose a reason for hiding this comment

botberry commented Dec 25, 2024

Apollo Federation Subgraph Compatibility Results

botberry commented Dec 25, 2024

botberry commented Dec 25, 2024

bellini666 commented Dec 25, 2024

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #3741 will not alter performance

Summary

codecov bot commented Dec 25, 2024

Codecov Report

bellini666 commented Dec 25, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Dec 25, 2024 •

edited

Loading