-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant and faulty test schema #3736
Remove redundant and faulty test schema #3736
Conversation
Reviewer's Guide by SourceryThis PR removes a redundant test schema that was specific to Litestar and replaces it with the shared schema used in other integration tests. This simplifies the test setup and ensures consistency across different test suites. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DoctorJohn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3736 +/- ##
==========================================
+ Coverage 97.12% 97.23% +0.10%
==========================================
Files 503 502 -1
Lines 33524 33421 -103
Branches 5507 5481 -26
==========================================
- Hits 32561 32496 -65
+ Misses 756 718 -38
Partials 207 207 |
CodSpeed Performance ReportMerging #3736 will not alter performanceComparing Summary
|
Description
Some Litestar-specific tests were using an outdated copy of the schema used by all other integration tests. This PR removes the redundant schema.
Types of Changes
Summary by Sourcery
Remove the redundant Litestar test schema and use the shared schema.
Enhancements:
Tests: