Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant and faulty test schema #3736

Conversation

DoctorJohn
Copy link
Member

@DoctorJohn DoctorJohn commented Dec 23, 2024

Description

Some Litestar-specific tests were using an outdated copy of the schema used by all other integration tests. This PR removes the redundant schema.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Summary by Sourcery

Remove the redundant Litestar test schema and use the shared schema.

Enhancements:

  • Use the shared schema for Litestar tests.

Tests:

  • Remove redundant Litestar-specific test schema.

Copy link
Contributor

sourcery-ai bot commented Dec 23, 2024

Reviewer's Guide by Sourcery

This PR removes a redundant test schema that was specific to Litestar and replaces it with the shared schema used in other integration tests. This simplifies the test setup and ensures consistency across different test suites.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the Litestar-specific test schema and updated the import to use the shared schema.
  • Removed the tests/litestar/schema.py file.
  • Updated the import in tests/litestar/app.py to use tests/views/schema instead of tests/litestar/schema.
tests/litestar/app.py
tests/litestar/schema.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DoctorJohn - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (d983130) to head (be5a87b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
+ Coverage   97.12%   97.23%   +0.10%     
==========================================
  Files         503      502       -1     
  Lines       33524    33421     -103     
  Branches     5507     5481      -26     
==========================================
- Hits        32561    32496      -65     
+ Misses        756      718      -38     
  Partials      207      207              

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #3736 will not alter performance

Comparing DoctorJohn:remove-redundant-and-faulty-test-schema (be5a87b) with main (d983130)

Summary

✅ 21 untouched benchmarks

@patrick91 patrick91 merged commit ad01dc5 into strawberry-graphql:main Dec 23, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants