-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix operation execution #3628
Fix operation execution #3628
Conversation
Closes #3625
Reviewer's Guide by SourceryThis pull request fixes an issue with operation execution in async mode, ensuring that extensions receive the correct result from the execution context. It also adds a new async test for the MaskErrors extension. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patrick91 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Release type: patch | ||
|
||
This release fixes an issue that prevented extensions to receive the result from | ||
the execution context when executing operations in async. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider rewording for clarity
The current wording is a bit ambiguous. Consider rephrasing to something like: 'This release fixes an issue that prevented extensions from receiving the result of asynchronous operations executed in the execution context.'
Thanks for adding the Here's a preview of the changelog: This release fixes an issue that prevented extensions to receive the result from Here's the tweet text:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3628 +/- ##
==========================================
- Coverage 96.75% 94.77% -1.99%
==========================================
Files 521 517 -4
Lines 33715 32573 -1142
Branches 5622 3768 -1854
==========================================
- Hits 32622 30871 -1751
- Misses 861 1408 +547
- Partials 232 294 +62 |
CodSpeed Performance ReportMerging #3628 will not alter performanceComparing Summary
|
Closed in favour of #3629 |
Closes #3625
Summary by Sourcery
Fix the async operation execution to ensure extensions receive the result from the execution context and add a corresponding test to verify error masking. Document the patch release in a new RELEASE.md file.
Bug Fixes:
Documentation:
Tests: