-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for generic inputs #3547
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3547 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 523 524 +1
Lines 33591 33629 +38
Branches 5573 5578 +5
=======================================
+ Hits 32439 32478 +39
+ Misses 916 915 -1
Partials 236 236 |
CodSpeed Performance ReportMerging #3547 will not alter performanceComparing Summary
Benchmarks breakdown
|
Reviewer's Guide by SourceryThis pull request introduces a new benchmark test for generic inputs in GraphQL queries. The changes include the addition of a new file, File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patrick91 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Going to merge this and make a new PR to (try to) fix it 😊 |
Only added a benchmark so far, based on #3544
Summary by Sourcery
Introduced a new benchmark test to evaluate the performance of generic GraphQL input handling, specifically focusing on filtering and querying operations.
test_generic_input.py
.