Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for generic inputs #3547

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Add benchmark for generic inputs #3547

merged 4 commits into from
Jun 24, 2024

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Jun 24, 2024

Only added a benchmark so far, based on #3544

Summary by Sourcery

Introduced a new benchmark test to evaluate the performance of generic GraphQL input handling, specifically focusing on filtering and querying operations.

  • Tests:
    • Added a benchmark test for generic GraphQL input handling, including a new test file test_generic_input.py.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (75450e2) to head (d98578a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3547   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         523      524    +1     
  Lines       33591    33629   +38     
  Branches     5573     5578    +5     
=======================================
+ Hits        32439    32478   +39     
+ Misses        916      915    -1     
  Partials      236      236           

Copy link

codspeed-hq bot commented Jun 24, 2024

CodSpeed Performance Report

Merging #3547 will not alter performance

Comparing bench-generic (d98578a) with main (39ccffc)

Summary

✅ 12 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main bench-generic Change
🆕 test_execute_generic_input N/A 3.1 s N/A

@patrick91 patrick91 changed the title WIP - Generic inputs performance Add benchmark for generic inputs Jun 24, 2024
@patrick91 patrick91 marked this pull request as ready for review June 24, 2024 18:55
Copy link
Contributor

sourcery-ai bot commented Jun 24, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new benchmark test for generic inputs in GraphQL queries. The changes include the addition of a new file, test_generic_input.py, which defines a GraphQLFilter class, Author and Book types, a Query class, and a test function test_execute_generic_input to benchmark the execution of a GraphQL query.

File-Level Changes

Files Changes
tests/benchmarks/test_generic_input.py Added a new benchmark test for generic inputs in GraphQL queries, including the definition of necessary types, schema, and a test function.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patrick91 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 3 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tests/benchmarks/test_generic_input.py Show resolved Hide resolved
tests/benchmarks/test_generic_input.py Show resolved Hide resolved
tests/benchmarks/test_generic_input.py Show resolved Hide resolved
@patrick91
Copy link
Member Author

Going to merge this and make a new PR to (try to) fix it 😊

@patrick91 patrick91 merged commit 095463d into main Jun 24, 2024
57 checks passed
@patrick91 patrick91 deleted the bench-generic branch June 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant