fix: Fix an issue preventing typing root with strawberry.Parent

[bellini666]

Fixes strawberry-graphql/strawberry-django#538

[sourcery-ai]

Hey @bellini666 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 4 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 1 issue found
• 🟢 Complexity: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Clarify the logic for checking parameter names.

The condition root_parameter.name != parent_parameter.name might benefit from a comment explaining why the names should not match. This will help future maintainers understand the rationale behind this check.

Suggested change

	and root_parameter.name != parent_parameter.name
	# Ensure the root and parent parameters do not refer to the same argument
	and root_parameter.name != parent_parameter.name

[sourcery-ai]

suggestion (testing): Consider adding a test for edge cases with null or invalid parent values.

To ensure robustness, it would be beneficial to add tests that handle cases where the parent parameter is None or an invalid type. This will help verify that the function behaves correctly under these conditions.

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

This release fixes a typing issue where trying to type a root argument with
strawberry.Parent would fail, like in the following example:

import strawberry


@strawberry.type
class SomeType:
    @strawberry.field
    def hello(self, root: strawberry.Parent[str]) -> str:
        return "world"

This should now work as intended.

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (6e790c1) to head (78595fe).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3529   +/-   ##
=======================================
  Coverage   96.55%   96.56%           
=======================================
  Files         523      523           
  Lines       33364    33404   +40     
  Branches     5522     5536   +14     
=======================================
+ Hits        32215    32255   +40     
  Misses        914      914           
  Partials      235      235           

[codspeed-hq]

CodSpeed Performance Report

Merging #3529 will not alter performance

_{Comparing fix_root_parent (78595fe) with main (6e790c1)}

Summary

✅ 12 untouched benchmarks