Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on 3.13 #3510

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Test on 3.13 #3510

merged 8 commits into from
Sep 11, 2024

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented May 24, 2024

:)

Summary by Sourcery

Add support for Python 3.13 by updating the nox configuration and GitHub Actions workflow. Enhance Pydantic tests by updating the version matrix. Include new documentation files for release announcements.

New Features:

  • Add support for Python 3.13 in the testing and build configurations.

Enhancements:

  • Update Pydantic test versions to include 2.9.0 and remove 2.7.0.

CI:

  • Update GitHub Actions workflow to include testing on Python 3.13-dev.

Documentation:

  • Add TWEET.md to announce the release and highlight the addition of Python 3.13 support.
  • Add RELEASE.md to document the patch release and the new Python 3.13 support.

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.76%. Comparing base (4ada2cc) to head (07e0c22).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
- Coverage   96.77%   96.76%   -0.02%     
==========================================
  Files         521      521              
  Lines       33731    33716      -15     
  Branches     5627     5622       -5     
==========================================
- Hits        32643    32624      -19     
- Misses        856      860       +4     
  Partials      232      232              

Copy link

codspeed-hq bot commented May 24, 2024

CodSpeed Performance Report

Merging #3510 will improve performances by 10.23%

Comparing python313-tests (07e0c22) with main (4ada2cc)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main python313-tests Change
test_execute 582.7 ms 528.7 ms +10.23%

@botberry
Copy link
Member

botberry commented May 24, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@patrick91 patrick91 marked this pull request as ready for review September 11, 2024 17:53
Copy link
Contributor

sourcery-ai bot commented Sep 11, 2024

Reviewer's Guide by Sourcery

This pull request adds support for Python 3.13 and updates the testing infrastructure to include Python 3.13. It also updates the Pydantic version range for testing and makes minor adjustments to improve compatibility with different Python versions.

File-Level Changes

Change Details Files
Add Python 3.13 support
  • Add Python 3.13 to the list of supported Python versions
  • Include Python 3.13-dev in the GitHub Actions test workflow
noxfile.py
.github/workflows/test.yml
Update Pydantic version range for testing
  • Replace Pydantic version 2.7.0 with 2.9.0 in the test configuration
noxfile.py
Improve compatibility with different Python versions
  • Move import of 'add_custom_init_fn' inside version-specific blocks
  • Add version check for Python < 3.10 in object_type.py
strawberry/experimental/pydantic/object_type.py
strawberry/types/object_type.py
Add release documentation
  • Create TWEET.md file with a template for announcing the release
  • Create RELEASE.md file specifying the release type and description
TWEET.md
RELEASE.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @patrick91 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -0,0 +1,3 @@
Release type: patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (documentation): Reconsider the release type for adding Python 3.13 support

Adding support for a new Python version might warrant a minor or major version bump, depending on the changes involved. Consider if 'patch' is the appropriate release type in this case.

Release type: minor

This release adds support for Python 3.13 (which will be out soon!)

@botberry
Copy link
Member

botberry commented Sep 11, 2024

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release adds support for Python 3.13 (which will be out soon!)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

This release adds support for Python 3.13 (which will be out soon!)

Get it here 👉 https://strawberry.rocks/release/(next)

@patrick91 patrick91 merged commit 29fa91d into main Sep 11, 2024
116 of 118 checks passed
@patrick91 patrick91 deleted the python313-tests branch September 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants