-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on 3.13 #3510
Test on 3.13 #3510
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3510 +/- ##
==========================================
- Coverage 96.77% 96.76% -0.02%
==========================================
Files 521 521
Lines 33731 33716 -15
Branches 5627 5622 -5
==========================================
- Hits 32643 32624 -19
- Misses 856 860 +4
Partials 232 232 |
CodSpeed Performance ReportMerging #3510 will improve performances by 10.23%Comparing Summary
Benchmarks breakdown
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
a3533ff
to
0b745d8
Compare
a904d57
to
1a69fc2
Compare
Reviewer's Guide by SourceryThis pull request adds support for Python 3.13 and updates the testing infrastructure to include Python 3.13. It also updates the Pydantic version range for testing and makes minor adjustments to improve compatibility with different Python versions. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @patrick91 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@@ -0,0 +1,3 @@ | |||
Release type: patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Reconsider the release type for adding Python 3.13 support
Adding support for a new Python version might warrant a minor or major version bump, depending on the changes involved. Consider if 'patch' is the appropriate release type in this case.
Release type: minor
This release adds support for Python 3.13 (which will be out soon!)
Thanks for adding the Here's a preview of the changelog: This release adds support for Python 3.13 (which will be out soon!) Here's the tweet text:
|
352ed02
to
07e0c22
Compare
:)
Summary by Sourcery
Add support for Python 3.13 by updating the nox configuration and GitHub Actions workflow. Enhance Pydantic tests by updating the version matrix. Include new documentation files for release announcements.
New Features:
Enhancements:
CI:
Documentation: