-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fallback primary key ordering unit tests #716
base: main
Are you sure you want to change the base?
Improve fallback primary key ordering unit tests #716
Conversation
Reviewer's Guide by SourceryThis PR adds unit tests to ensure that pre-existing ordering from various sources (model Meta, get_queryset, GraphQL) is respected when using the fallback primary key ordering feature introduced in PR #715. It includes new tests and a new Quiz model to test the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SupImDos - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding comments to the tests to explain the expected ordering behavior in each case.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Hi @bellini666, SourceryAI suggested some useful unit tests in the last PR (#715) that I hadn't committed yet (whoops). There's no new functionality here, just some extra tests if you wanted them 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
=======================================
Coverage 88.13% 88.13%
=======================================
Files 42 42
Lines 3853 3853
=======================================
Hits 3396 3396
Misses 457 457 ☔ View full report in Codecov by Sentry. |
Description
PR #715 introduced default fallback primary key ordering for unordered querysets. This PR adds some extra unit tests, to ensure that pre-existing ordering from various sources is still respected.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Tests:
get_queryset
ordering, and GraphQL ordering.