Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include strava_model in type checking #407

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

enadeau
Copy link
Contributor

@enadeau enadeau commented Aug 15, 2023

Relates to #373

Description

Includes the newly fixed strava_model.py file in type checking

Type of change

Select the statement best describes this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This is a documentation update
  • Other (please describe)

Does your PR include tests

If you are fixing a bug or adding a feature, we appreciate (but do not require)
tests to support whatever fix of feature you're implementing.

  • Yes
  • No, i'd like some help with tests
  • This change doesn't require tests

Did you include your contribution to the change log?

  • Yes, changelog.md is up-to-date.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #407 (209834a) into master (0ef2dca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   86.86%   86.86%           
=======================================
  Files          10       10           
  Lines        1690     1690           
  Branches      152      152           
=======================================
  Hits         1468     1468           
  Misses        180      180           
  Partials       42       42           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, @enadeau thank you!! i'll approve and merge as it's a small but important update!!

@lwasser lwasser merged commit aa36851 into stravalib:master Aug 16, 2023
@enadeau enadeau deleted the mypy-strava-model branch August 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants