Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type annotation for exc.py #377

Merged
merged 1 commit into from
Jun 30, 2023
Merged

type annotation for exc.py #377

merged 1 commit into from
Jun 30, 2023

Conversation

enadeau
Copy link
Contributor

@enadeau enadeau commented Jun 29, 2023

Description

More work related to #373. This took it easy and did the exception file.

Type of change

Select the statement best describes this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This is a documentation update
  • Other (please describe)

Does your PR include tests

If you are fixing a bug or adding a feature, we appreciate (but do not require)
tests to support whatever fix of feature you're implementing.

  • Yes
  • No, i'd like some help with tests
  • This change doesn't require tests

Did you include your contribution to the change log?

  • Yes, changelog.md is up-to-date.

If you are having a hard time getting the tests to run correctly feel free to
ping one of the maintainers here!

Copy link
Collaborator

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with this pr!! approved ✨

@lwasser lwasser merged commit 1bb82be into stravalib:master Jun 30, 2023
@lwasser
Copy link
Collaborator

lwasser commented Jun 30, 2023

@enadeau thank you again for this!!

@enadeau enadeau deleted the type-exc branch June 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants