Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use rust stable for semver CI #1104

Merged
merged 1 commit into from
Aug 15, 2024
Merged

use rust stable for semver CI #1104

merged 1 commit into from
Aug 15, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Aug 14, 2024 •
edited
Loading

cargo semver-checks had a new release a couple hours ago: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.34.0

this release changed MSRV of cargo semver-checks from 1.75 to 1.77

currently, semver-check.yaml is installing 1.75:

stratum/.github/workflows/semver-check.yaml

Lines 21 to 25 in a090844

- name: Install Rust 1.75.0
uses: actions-rs/toolchain@v1
with:
toolchain: 1.75.0
override: true

as a consequence, our entire SemVer CI is failing with:

Run cargo semver-checks
error: rustc version is not high enough: >=1.77.0 needed, got 1.75.0

HELP: to use the latest rustc, run `rustup update stable && cargo +stable semver-checks <args>`

example

this PR changes 1.75 to stable on semver-check.yaml, so that we don't face this issue again in the future

Shourya742
Shourya742 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportThu, August 15, 2024 at 13:02:43 UTC
ProjectStratum v2 (SRI)
Branchmsrv-cargo-semver-check
Testbedsv2

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_mining_message_submit_standardLatency (nanoseconds (ns))🚨 (view plot | view alert)14.73 (+0.51%)14.70 (100.21%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.49 (-0.14%)45.24 (98.35%)
client_sv2_handle_message_mining✅ (view plot)72.48 (-0.48%)80.35 (90.21%)
client_sv2_mining_message_submit_standard🚨 (view plot | view alert)14.73 (+0.51%)14.70 (100.21%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)272.66 (+3.02%)284.53 (95.83%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)582.38 (-1.97%)627.80 (92.77%)
client_sv2_open_channel✅ (view plot)161.59 (-2.59%)173.49 (93.14%)
client_sv2_open_channel_serialize✅ (view plot)273.79 (-3.24%)293.49 (93.29%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)377.94 (-0.11%)423.91 (89.15%)
client_sv2_setup_connection✅ (view plot)165.19 (+0.62%)174.91 (94.44%)
client_sv2_setup_connection_serialize✅ (view plot)450.45 (-4.95%)506.83 (88.88%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)967.16 (-0.41%)1,039.00 (93.09%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportThu, August 15, 2024 at 13:02:43 UTC
ProjectStratum v2 (SRI)
Branchmsrv-cargo-semver-check
Testbedsv1

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_handle_authorizeL2 Accesses (accesses)🚨 (view plot | view alert)67.00 (+13.70%)65.28 (102.63%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,477.00 (+0.49%)8,724.62 (97.16%)✅ (view plot)3,749.00 (+0.23%)3,855.78 (97.23%)✅ (view plot)5,252.00 (+0.13%)5,402.18 (97.22%)✅ (view plot)8.00 (+0.46%)10.40 (76.90%)✅ (view plot)91.00 (+1.09%)93.98 (96.83%)
get_submit✅ (view plot)95,442.00 (-0.12%)96,143.37 (99.27%)✅ (view plot)59,442.00 (-0.05%)59,779.69 (99.44%)✅ (view plot)85,357.00 (-0.06%)85,837.99 (99.44%)✅ (view plot)57.00 (+3.16%)62.54 (91.15%)✅ (view plot)280.00 (-0.73%)287.71 (97.32%)
get_subscribe✅ (view plot)7,926.00 (-0.63%)8,271.07 (95.83%)✅ (view plot)2,844.00 (+0.50%)2,940.20 (96.73%)✅ (view plot)3,976.00 (+0.56%)4,100.09 (96.97%)✅ (view plot)13.00 (-19.66%)19.82 (65.60%)✅ (view plot)111.00 (-1.44%)116.95 (94.91%)
serialize_authorize✅ (view plot)12,196.00 (-0.08%)12,502.48 (97.55%)✅ (view plot)5,320.00 (+0.16%)5,426.78 (98.03%)✅ (view plot)7,416.00 (+0.11%)7,565.54 (98.02%)✅ (view plot)11.00 (+1.68%)13.39 (82.15%)✅ (view plot)135.00 (-0.39%)140.19 (96.30%)
serialize_deserialize_authorize✅ (view plot)24,497.00 (+0.11%)24,707.37 (99.15%)✅ (view plot)9,901.00 (+0.01%)10,026.73 (98.75%)✅ (view plot)13,962.00 (-0.03%)14,151.82 (98.66%)✅ (view plot)35.00 (-4.42%)41.57 (84.19%)✅ (view plot)296.00 (+0.39%)297.70 (99.43%)
serialize_deserialize_handle_authorize✅ (view plot)30,294.00 (+0.49%)30,345.41 (99.83%)✅ (view plot)12,104.00 (+0.07%)12,210.78 (99.13%)✅ (view plot)17,114.00 (-0.02%)17,280.51 (99.04%)🚨 (view plot | view alert)67.00 (+13.70%)65.28 (102.63%)✅ (view plot)367.00 (+0.86%)367.08 (99.98%)
serialize_deserialize_handle_submit✅ (view plot)126,328.00 (-0.07%)127,032.76 (99.45%)✅ (view plot)73,224.00 (-0.04%)73,621.57 (99.46%)✅ (view plot)104,943.00 (-0.04%)105,513.83 (99.46%)✅ (view plot)126.00 (+4.46%)131.53 (95.79%)✅ (view plot)593.00 (-0.30%)599.20 (98.96%)
serialize_deserialize_handle_subscribe✅ (view plot)27,446.00 (-0.03%)27,601.49 (99.44%)✅ (view plot)9,646.00 (+0.15%)9,742.20 (99.01%)✅ (view plot)13,641.00 (+0.13%)13,775.96 (99.02%)✅ (view plot)66.00 (+0.06%)73.82 (89.41%)✅ (view plot)385.00 (-0.20%)388.54 (99.09%)
serialize_deserialize_submit✅ (view plot)114,955.00 (-0.11%)115,655.04 (99.39%)✅ (view plot)68,001.00 (-0.08%)68,404.14 (99.41%)✅ (view plot)97,555.00 (-0.10%)98,152.60 (99.39%)✅ (view plot)71.00 (+2.09%)75.29 (94.30%)✅ (view plot)487.00 (-0.22%)492.35 (98.91%)
serialize_deserialize_subscribe✅ (view plot)22,819.00 (-0.24%)23,111.23 (98.74%)✅ (view plot)8,198.00 (+0.15%)8,297.94 (98.80%)✅ (view plot)11,549.00 (+0.17%)11,683.48 (98.85%)✅ (view plot)35.00 (-11.13%)44.14 (79.30%)✅ (view plot)317.00 (-0.47%)321.49 (98.60%)
serialize_submit✅ (view plot)99,721.00 (-0.17%)100,471.85 (99.25%)✅ (view plot)61,486.00 (-0.05%)61,829.09 (99.45%)✅ (view plot)88,206.00 (-0.05%)88,691.56 (99.45%)✅ (view plot)56.00 (+0.29%)62.14 (90.12%)✅ (view plot)321.00 (-1.11%)329.25 (97.49%)
serialize_subscribe✅ (view plot)11,229.00 (-0.85%)11,607.25 (96.74%)✅ (view plot)4,191.00 (+0.34%)4,287.20 (97.76%)✅ (view plot)5,834.00 (+0.38%)5,959.35 (97.90%)✅ (view plot)15.00 (-8.33%)18.98 (79.05%)✅ (view plot)152.00 (-2.05%)159.81 (95.11%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportThu, August 15, 2024 at 13:02:43 UTC
ProjectStratum v2 (SRI)
Branch1104/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,507.60 (-6.08%)7,348.62 (88.56%)
client-submit-serialize-deserialize✅ (view plot)7,392.70 (-5.80%)8,335.13 (88.69%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)7,974.80 (-5.23%)8,847.13 (90.14%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)870.13 (-3.07%)927.59 (93.80%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)674.80 (-3.10%)718.68 (93.89%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)236.95 (-4.39%)255.90 (92.59%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)152.57 (-2.84%)162.57 (93.85%)
client-sv1-get-submit✅ (view plot)6,350.20 (-5.16%)7,137.17 (88.97%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)268.79 (-3.43%)291.44 (92.23%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)734.54 (-1.62%)775.97 (94.66%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)601.75 (-1.99%)637.73 (94.36%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)202.25 (-2.11%)220.00 (91.93%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

🐰Bencher

ReportThu, August 15, 2024 at 13:02:44 UTC
ProjectStratum v2 (SRI)
Branchmsrv-cargo-semver-check
Testbedsv2

🚨 8 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonEstimated Cycles (estimated cycles)🚨 (view plot | view alert)2,141.00 (+4.39%)2,132.34 (100.41%)
client_sv2_handle_message_commonRAM Accesses (accesses)🚨 (view plot | view alert)39.00 (+6.31%)38.70 (100.76%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.45%)10,568.30 (100.21%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,405.00 (+0.42%)15,374.75 (100.20%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.53%)8,009.69 (100.22%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,678.00 (+0.54%)11,649.53 (100.24%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.29%)14,837.01 (100.12%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,816.00 (+0.29%)21,786.20 (100.14%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common🚨 (view plot | view alert)2,141.00 (+4.39%)2,132.34 (100.41%)✅ (view plot)473.00 (+0.49%)486.40 (97.25%)✅ (view plot)731.00 (-0.16%)755.22 (96.79%)✅ (view plot)9.00 (+28.91%)10.81 (83.22%)🚨 (view plot | view alert)39.00 (+6.31%)38.70 (100.76%)
client_sv2_handle_message_mining✅ (view plot)8,223.00 (+0.31%)8,336.78 (98.64%)✅ (view plot)2,143.00 (+0.73%)2,171.62 (98.68%)✅ (view plot)3,173.00 (+0.89%)3,216.73 (98.64%)✅ (view plot)30.00 (-21.81%)43.99 (68.20%)✅ (view plot)140.00 (+0.81%)142.01 (98.58%)
client_sv2_mining_message_submit_standard✅ (view plot)6,354.00 (+1.23%)6,391.96 (99.41%)✅ (view plot)1,756.00 (+0.36%)1,763.42 (99.58%)✅ (view plot)2,559.00 (+0.20%)2,576.10 (99.34%)✅ (view plot)17.00 (-2.75%)22.60 (75.21%)✅ (view plot)106.00 (+2.05%)107.01 (99.06%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,877.00 (+0.67%)15,037.63 (98.93%)✅ (view plot)4,700.00 (+0.14%)4,707.42 (99.84%)✅ (view plot)6,757.00 (+0.04%)6,775.36 (99.73%)✅ (view plot)49.00 (+3.56%)52.22 (93.83%)✅ (view plot)225.00 (+1.14%)230.06 (97.80%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,655.00 (+0.63%)27,850.96 (99.30%)🚨 (view plot | view alert)10,591.00 (+0.45%)10,568.30 (100.21%)🚨 (view plot | view alert)15,405.00 (+0.42%)15,374.75 (100.20%)✅ (view plot)84.00 (+0.33%)89.34 (94.02%)✅ (view plot)338.00 (+0.93%)345.42 (97.85%)
client_sv2_open_channel✅ (view plot)4,341.00 (-3.31%)4,615.56 (94.05%)✅ (view plot)1,461.00 (+0.06%)1,474.45 (99.09%)✅ (view plot)2,161.00 (+0.38%)2,173.21 (99.44%)✅ (view plot)9.00 (-24.53%)15.29 (58.87%)✅ (view plot)61.00 (-6.23%)68.31 (89.30%)
client_sv2_open_channel_serialize✅ (view plot)14,092.00 (-0.87%)14,461.58 (97.44%)✅ (view plot)5,064.00 (+0.02%)5,077.45 (99.74%)✅ (view plot)7,322.00 (+0.06%)7,339.38 (99.76%)✅ (view plot)38.00 (+1.94%)42.01 (90.45%)✅ (view plot)188.00 (-1.95%)198.91 (94.51%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,653.00 (+0.05%)23,024.76 (98.39%)🚨 (view plot | view alert)8,027.00 (+0.53%)8,009.69 (100.22%)🚨 (view plot | view alert)11,678.00 (+0.54%)11,649.53 (100.24%)✅ (view plot)74.00 (+0.93%)81.86 (90.40%)✅ (view plot)303.00 (-0.50%)314.98 (96.20%)
client_sv2_setup_connection✅ (view plot)4,715.00 (+0.35%)4,765.31 (98.94%)✅ (view plot)1,502.00 (+0.05%)1,515.45 (99.11%)✅ (view plot)2,275.00 (-0.08%)2,299.71 (98.93%)✅ (view plot)12.00 (+31.44%)13.68 (87.73%)✅ (view plot)68.00 (+0.16%)69.64 (97.65%)
client_sv2_setup_connection_serialize✅ (view plot)16,176.00 (-0.54%)16,491.76 (98.09%)✅ (view plot)5,963.00 (+0.01%)5,976.45 (99.77%)✅ (view plot)8,656.00 (+0.01%)8,677.61 (99.75%)✅ (view plot)48.00 (+7.42%)49.12 (97.72%)✅ (view plot)208.00 (-1.42%)217.55 (95.61%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,636.00 (+0.28%)35,751.35 (99.68%)🚨 (view plot | view alert)14,855.00 (+0.29%)14,837.01 (100.12%)🚨 (view plot | view alert)21,816.00 (+0.29%)21,786.20 (100.14%)✅ (view plot)97.00 (-2.59%)112.66 (86.10%)✅ (view plot)381.00 (+0.37%)384.65 (99.05%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@plebhash plebhash merged commit 742dfd1 into stratum-mining:dev Aug 15, 2024
33 checks passed
@plebhash plebhash deleted the msrv-cargo-semver-check branch August 15, 2024 13:18
@Fi3
Copy link
Collaborator

Fi3 commented Aug 17, 2024 •
edited
Loading

I strongly suggest to NOT change MSRV as we want, otherwise having an MSRV is not of any utility. For example here we change it ONLY for support something that we need on dev/release env no reason to bump MSRV for it, we can just use the right version when we run semver check. Our libraries do not need 1.77 they can work with 1.75 without any issue. So we should change MSRV only if we really need to use some feature added by a new rust version, or MAYBE (?) better we can define MSRV as the last n version so it get "automatically" increased.

@plebhash plebhash mentioned this pull request Aug 17, 2024
Closed
@plebhash
Copy link
Collaborator Author

I strongly suggest to NOT change MSRV as we want, otherwise having an MSRV is not of any utility. For example here we change it ONLY for support something that we need on dev/release env no reason to bump MSRV for it, we can just use the right version when we run semver check. Our libraries do not need 1.77 they can work with 1.75 without any issue. So we should change MSRV only if we really need to use some feature added by a new rust version, or MAYBE (?) better we can define MSRV as the last n version so it get "automatically" increased.

please see #1110

@plebhash plebhash mentioned this pull request Aug 18, 2024
Merged
@GitGab19
Copy link
Collaborator

I strongly suggest to NOT change MSRV as we want, otherwise having an MSRV is not of any utility. For example here we change it ONLY for support something that we need on dev/release env no reason to bump MSRV for it, we can just use the right version when we run semver check. Our libraries do not need 1.77 they can work with 1.75 without any issue. So we should change MSRV only if we really need to use some feature added by a new rust version, or MAYBE (?) better we can define MSRV as the last n version so it get "automatically" increased.

This PR did not change MSRV, it changed just the version installed in the CI to run semver-checks.
Am I missing something? I can't fully understand this comment

@Fi3
Copy link
Collaborator

Fi3 commented Aug 19, 2024 •
edited
Loading

Not sure from branch name and form description I supposed the pr goal was changing MSRV but if is not so diregard my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shourya742 Shourya742 Shourya742 approved these changes

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plebhash @Fi3 @GitGab19 @Shourya742