[Masternode] Offline signing endpoints #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowandh
force-pushed
the
offline-signing
branch
2 times, most recently
from
994875c to
2a11b18
Compare
rowandh
force-pushed
the
offline-signing
branch
from
2a11b18 to
db60245
Compare
|
Hi Rowan, what was the requirement for this? (Looks good though) |
|
Nothing formal AFAIK, just thought it might be more useful to split the method up this way to enable an offline collateral address to join. |
zeptin
reviewed
Jun 7, 2021
| @@ -92,16 +72,76 @@ public async Task<PubKey> JoinFederationAsync(JoinFederationRequestModel request | |||
| throw new Exception($"The call to sign the join federation request failed: '{err.Message}'."); | |||
| } | |||
|
|
|||
| if (!VerifyCollateralSignature(joinRequest)) | |||
There was a problem hiding this comment.
You check this inside BroadcastSignedJoinRequestAsync too - as that method gets called in two places it makes sense to keep the if inside it only
zeptin
reviewed
Jun 7, 2021
| /// <summary> | ||
| /// Called by a miner wanting to join the federation. | ||
| /// </summary> | ||
| /// <param name="request">See <see cref="JoinFederationRequestModel"></see>.</param> |
zeptin
reviewed
Jun 7, 2021
| /// <summary> | ||
| /// Called by a miner wanting to join the federation. | ||
| /// </summary> | ||
| /// <param name="request">See <see cref="JoinFederationRequestModel"></see>.</param> |
There was a problem hiding this comment.
JoinFederationRequestWithSignature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new endpoints
Add verification of the collateral signature