Add WrappedToken.sol #1095
Draft
Add WrappedToken.sol #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms-fees-ort Add activation height for multisig fee sorting
noescape00
reviewed
Nov 17, 2022
| // When the tokens are burnt we need to know where to credit the equivalent value on the Stratis chain. | ||
| // Currently it is only possible to assign a single address here, so if multiple recipients are required | ||
| // the burner will have to wait until each burn is processed before proceeding with the next. | ||
| withdrawalAddresses[msg.sender] = address; |
There was a problem hiding this comment.
maybe add additional method with onlyOwner modifier that removes value withdrawalAddresses[address].
And in burn method if address is set- revert.
That will prevent users sending requests with multiple recepients in a row before prev requests are processed and subsequently loosing money
There was a problem hiding this comment.
@noescape00 , I've made the following change:
string memory key = string(abi.encodePacked(msg.sender, " ", burnId));
withdrawalAddresses[key] = tokenAddress;
Trying to clean-up the dictionary may not be worth the additional costs for each multisig node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.