Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for releasing loopdev-3 package #496

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Add support for releasing loopdev-3 package #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc246f
Add support for releasing loopdev-3 package
mulkieran Dec 20, 2023
454b9c9
Do not get the changelog eagerly
mulkieran Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release_management/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def get_package_info(manifest_abs_path, package_name):

package = metadata["package"]
assert package["name"] == package_name, (
f'crate name in Cargo.toml ({package["name"]}) != specified'
f'package name in Cargo.toml ({package["name"]}) != specified'
f"package name ({package_name})"
)
github_repo = urlparse(package["repository"].rstrip("/"))
Expand Down
6 changes: 3 additions & 3 deletions release_management/create_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,15 +230,13 @@ def tag_rust_library(namespace, name):
"__main__._push_tag", lambda: _push_tag(repository.geturl(), tag)
)

changelog_url = get_changelog_url(repository.geturl(), get_branch())

dry_run_caller(
"__main__.create_release",
lambda: create_release(
repository,
tag,
release_version,
changelog_url,
get_changelog_url(repository.geturl(), get_branch()),
additional_assets=additional_assets,
),
skip=namespace.no_github_release,
Expand Down Expand Up @@ -370,6 +368,8 @@ def _create_rust_subcommands(subparsers):

RustCrates.set_up_subcommand("stratisd_proc_macros", subparsers)

RustCrates.set_up_subcommand("loopdev-3", subparsers, subcmd_aliases=["loopdev"])


def _create_python_subcommands(subparsers):
PythonPackages.set_up_subcommand(
Expand Down