Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing city and zip in billing address even when missing a state #3240

Merged

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Some addresses, such as those in Belgium, have cities and postal codes but not states. Currently in PMPro, if a state is not present, we do not show the city or postal code. This PR updates PMPro to account for these types of addresses.

Resolves XXX.

How to test the changes in this Pull Request:

  1. Set up Stripe Checkout to always collect billing address
  2. Check out using a Belgian billing address
  3. See that city and zip were not shown in PMPro email/orders page before this PR, but are afterwards.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005 dparker1005 marked this pull request as ready for review January 3, 2025 15:36
@dparker1005 dparker1005 merged commit 64f679d into strangerstudios:dev Jan 8, 2025
@dparker1005 dparker1005 deleted the showing-city-when-missing-state branch January 8, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants